Include git ref in website download zip name#2339
Open
C85297 wants to merge 3 commits intogchq:masterfrom
Open
Include git ref in website download zip name#2339C85297 wants to merge 3 commits intogchq:masterfrom
C85297 wants to merge 3 commits intogchq:masterfrom
Conversation
Contributor
|
I'm not sure if this is just because the interim builds are done differently, but if I download the build artefact for this PR from https://github.com/gchq/CyberChef/pull/2339/checks, unzip (twice) and serve it up (eg using python3 -m http.server) then the download page looks like this (note placeholder for hash) |
Member
Author
|
@GCHQDeveloper581 that is odd... Could it be this? https://github.com/orgs/community/discussions/26325#discussioncomment-3251462 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently the file available from the "Download CyberChef" button on the website includes the version of the latest CyberChef release. This is often inaccurate, as if the website was generated from new commits after a release, the zip will include those changes, and will not match the GitHub release contents.
This change includes the commit ref in the zip file to make clear its source.
Existing Issue
Closes #2081
AI disclosure
GPT 5.5
Test Coverage
Functionality covered by existing tests