Add in rules for package managers for cooldown (and a few other rules for pnpm)#1
Open
gbennett-squarespace wants to merge 12 commits into
Open
Add in rules for package managers for cooldown (and a few other rules for pnpm)#1gbennett-squarespace wants to merge 12 commits into
gbennett-squarespace wants to merge 12 commits into
Conversation
Clarified the message regarding the cooldown period for Dependabot updates.
Consolidate warning message for missing minimum release age.
Clarify the message for the pnpm-block-exotic-sub-dependencies rule.
Added a warning about missing minimum release age in pnpm configuration.
Updated trust policy message to include guidance on setting 'trustPolicy: no-downgrade' for security.
Document the minimum release age for package updates.
Updated message to simplify instructions for setting a dependency cooldown in uv.
Removed example for npmMinimalAgeGate in the YAML configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to an issue, if relevant
Inspired by recent events and this PR:
semgrep#3791
Rules added:
Cooldown/Minimum Age for:
NPM: vun, pnpm, renovate, yarn
Python: uv
For pnpm also add rules for block exotic subdependencies and trust policy, both related settings to help avoid installing malicious packages.
Rules have been tested in our environment with good success.
One semi-false positive is because
pyproject.tomlcan be used by other package managers (Poetry for example), it'll flag it as missing the setting. Also, if the repo is on too old a version of a package manager, it still flags it. Neither of these are easily solved in the context of the rule running.In both cases I think there's still a strong argument for raising the finding, as it highlights a security gap in the environment.