Skip to content

build: add cmake support for qt6#214

Open
dabbinavo wants to merge 1 commit intoftylitak:masterfrom
dabbinavo:feature/qt6-cmake-support
Open

build: add cmake support for qt6#214
dabbinavo wants to merge 1 commit intoftylitak:masterfrom
dabbinavo:feature/qt6-cmake-support

Conversation

@dabbinavo
Copy link
Copy Markdown

@dabbinavo dabbinavo commented Dec 29, 2021

features:

fixes:

  • revert minimum required cmake version to 3.2 (was incremented accidentally in commit ebb3e5e)
  • remove duplicate compile definitions for 1D barcode support
  • include qt components multimedia, svg, quick and quickcontrols2 only when neccessary

Copy link
Copy Markdown

@EndrII EndrII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but has some issues. please fix.

Comment thread src/CMakeLists.txt Outdated
Comment thread src/CMakeLists.txt Outdated
features:
- add option to specify target qt version
- dynamically locate QT version and use version specific components and linker targets (also see https://doc.qt.io/qt-6/cmake-qt5-and-qt6-compatibility.html#supporting-older-qt-5-versions)

fixes:
- revert minimum required cmake version to 3.2 (was incremented accidentally in commit ebb3e5e)
- remove duplicate compile definitions for 1D barcode support
- include qt components multimedia, svg, quick and quickcontrols2 only when neccessary
@dabbinavo dabbinavo force-pushed the feature/qt6-cmake-support branch from 3045477 to 0b1fbbe Compare December 29, 2021 08:47
Comment thread src/CMakeLists.txt
Copy link
Copy Markdown

@EndrII EndrII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me. But i can't check build manually

@dabbinavo
Copy link
Copy Markdown
Author

looks good for me. But i can't check build manually

@EndrII, what do you mean by "can't check build manually"

I successfully build the library for Qt5.15.2 and Qt6.2.2 with the following settings (total of 4 builds):

Build A

cmake_minimum_required(VERSION 3.2)

project(test)

SET(QZXING_MULTIMEDIA ON)
SET(QZXING_USE_DECODER_1D_BARCODES ON)
SET(QZXING_USE_DECODER_QR_CODE ON)
add_subdirectory(ext/qzxing/src)

Build B

cmake_minimum_required(VERSION 3.2)

project(test)

SET(QZXING_USE_ENCODER ON)
add_subdirectory(ext/qzxing/src)

@EndrII
Copy link
Copy Markdown

EndrII commented Dec 29, 2021

Where are BOSS of this project ?)
@ftylitak please check this PR and merge if all is good.

@dabbinavo
Copy link
Copy Markdown
Author

@ftylitak anything missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants