npm: bump typescript from 5.9.3 to 6.0.2#333
Open
dependabot[bot] wants to merge 4 commits intomainfrom
Open
Conversation
25378db to
978d5a9
Compare
Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.9.3 to 6.0.2. - [Release notes](https://github.com/microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v5.9.3...v6.0.2) --- updated-dependencies: - dependency-name: typescript dependency-version: 6.0.2 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
978d5a9 to
60f5d29
Compare
Member
this adds typing to places where it was missing before:
## Behaviour-preserving refactors (old { foo: undefined } pattern)
That pattern made properties infer as literal undefined, which breaks under strict checking. Many modules were updated to either fully built objects (e.g. container.ts, math.ts, forcegraph/draw.ts, utils/node.ts, sidebar.ts, legend.ts, title.ts, tabs.ts, linklist.ts, nodelist.ts, sorttable.ts) or typed stubs + assignments where needed.
## Notable file changes
lib/utils/version.ts: Rewritten as a class so this and new are correctly typed.
lib/utils/router.ts: Uses ObjectsLinksAndNodes for objects / setData, safer handling of nodeDict, and routeGroup for regex capture data; Target.gotoNode matches real usage (node, nodeDict).
lib/map/button.js → lib/map/button.ts: Migrated with // @ts-nocheck at the top (Leaflet extend typing is awkward without a large Leaflet-specific layer).
lib/forcegraph.ts: Stricter typing for graph state, forceLink.links!(…), MapLink initial x/y, and gotoNode/gotoLink return arrays instead of calling resetView() where a coordinate array is required.
lib/proportions.ts: Stubs, GenericFilter vs Filter in watchFilters, gateway modifier return type, showStat pushed into a VNode[] via cast (it returns HTMLDivElement).
lib/infobox/main.ts: Avoids Node / Link name clashes with DOM/utils/node, uses an InfoboxPanel type and as unknown as for panel instances.
lib/infobox/link.ts and lib/infobox/node.ts: // @ts-nocheck to limit scope while keeping behaviour.
Member
|
I wondered if Cursor AI can help here, as this is mostly typing and code migration without functionality changes. |
Contributor
Author
|
A newer version of typescript exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps typescript from 5.9.3 to 6.0.2.
Release notes
Sourced from typescript's releases.
Commits
607a22aBump version to 6.0.2 and LKG9e72ab7🤖 Pick PR #63239 (Fix missing lib files in reused pro...) into release-6.0 (#...35ff23d🤖 Pick PR #63163 (Port anyFunctionType subtype fix an...) into release-6.0 (#...e175b69Bump version to 6.0.1-rc and LKGaf4caacUpdate LKG8efd7e8Merge remote-tracking branch 'origin/main' into release-6.0206ed1aDeprecate assert in import() (#63172)e688ac8Update dependencies (#63156)29b300dBump the github-actions group across 1 directory with 2 updates (#63205)0c2c7a3DOM update (#63183)