Skip to content

Address TODO items in TeleopDriveCommand requiring robot testing #5

Description

@coderabbitai

Context

These TODO items in TeleopDriveCommand.kt need to be addressed once robot hardware is available for testing.

Source: PR #4, comment: #4 (comment)
Requested by: @Baconing

TODO Items

1. Missing Constants

Lines 63, 64, 70, 78 have TODO("requires constants") placeholders that need actual constant values:

  • xSpeed calculation (line 63)
  • ySpeed calculation (line 64)
  • Rotation speed in field-relative mode (line 70)
  • Rotation speed in robot-relative mode (line 78)

These likely need PhysicalConstants.MAX_SPEED and PhysicalConstants.MAX_ANGULAR_VELOCITY or similar.

2. Verify Robot-Relative ChassisSpeeds Logic (Line 74)

Code was changed from 2025 codebase. Verify correctness before competition or revert to 2025 implementation.

3. Verify applyCurveToTranslation Implementation (Line 88)

Code was changed from 2025 codebase. Verify correctness before competition or revert to 2025 implementation.

Action Items

  • Define and add missing constants for speed calculations
  • Test robot-relative control behavior with hardware
  • Test field-relative control behavior with hardware
  • Verify translation curve application matches expected behavior
  • Compare with 2025 codebase if issues arise

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions