Skip to content

Refactor mssqlshell.py to improve code structure #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshnair75567-cloud wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

Refactor mssqlshell.py to improve code structure #2189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions impacket/examples/mssqlshell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,11 @@ def execute_as(self, exec_as):
self.print_replies()

def do_exec_as_login(self, s):
exec_as = "execute as login='%s';" % s
exec_as = "execute as login='%s';" % s.replace("'", "''")
self.execute_as(exec_as)

def do_exec_as_user(self, s):
exec_as = "execute as user='%s';" % s
exec_as = "execute as user='%s';" % s.replace("'", "''")
self.execute_as(exec_as)

def do_use_link(self, s):
Expand Down Expand Up @@ -236,15 +236,15 @@ def do_upload(self, line):

def do_xp_dirtree(self, s):
try:
self.sql_query("exec master.sys.xp_dirtree '%s',1,1" % s)
self.sql_query("exec master.sys.xp_dirtree '%s',1,1" % s.replace("'", "''"))
self.print_replies()
self.sql.printRows()
except:
pass

def do_xp_cmdshell(self, s):
try:
self.sql_query("exec master..xp_cmdshell '%s'" % s)
self.sql_query("exec master..xp_cmdshell '%s'" % s.replace("'", "''"))
self.print_replies()
self.sql.colMeta[0]['TypeData'] = 80*2
self.sql.printRows()
Expand All @@ -260,7 +260,7 @@ def do_sp_start_job(self, s):
"EXEC msdb..sp_add_jobstep @job_name=@job,@step_id=1,@step_name='Defragmentation',"
"@subsystem='CMDEXEC',@command='%s',@on_success_action=1;"
"EXEC msdb..sp_add_jobserver @job_name=@job;"
"EXEC msdb..sp_start_job @job_name=@job;" % s)
"EXEC msdb..sp_start_job @job_name=@job;" % s.replace("'", "''"))
self.print_replies()
self.sql.printRows()
except:
Expand Down