[wmi] Allow set qualifier in addNewAttribute and remove print in marshalMe#2175
Open
XiaoliChan wants to merge 2 commits into
Open
[wmi] Allow set qualifier in addNewAttribute and remove print in marshalMe#2175XiaoliChan wants to merge 2 commits into
addNewAttribute and remove print in marshalMe#2175XiaoliChan wants to merge 2 commits into
Conversation
XiaoliChan
changed the title
addNewAttribute
Signed-off-by: xiaolichan <2209553467@qq.com>
Signed-off-by: XiaoliChan <30458572+XiaoliChan@users.noreply.github.com>
XiaoliChan
force-pushed
the
wmi-qualifier-support
branch
from
3f3b4ba to
52630c6
Compare
XiaoliChan
changed the title
addNewAttributeaddNewAttribute and remove print in marshalMe
Contributor
Author
|
Ping @anadrianmanrique |
anadrianmanrique
added
the
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has two fixes included.
Without it, we can't
GetObjectwith key value like in our new class, which created byPutClassprintinmarshalMefuncAlso, the
printfunction in marshalMe doesn't make sense, because it always prints the structure before PutInstance, which will consume a lot of resources when submitting large stuff.