Add composer attachments and harden ACP session handling

.github/workflows/ci.yml

@@ -56,11 +56,14 @@ jobs:
           sudo apt-get update
           sudo apt-get install -y libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf
 
-      - name: Install frontend dependencies
-        run: npm ci
-
-      - name: Type check
-        run: npm run build
+      - name: Install frontend dependencies
+        run: npm ci
+
+      - name: Run tests
+        run: npm test
+
+      - name: Type check
+        run: npm run build
 
       - name: Build Tauri app
         uses: tauri-apps/tauri-action@v0

.sisyphus/evidence/task-1-ci-step.txt

@@ -0,0 +1,2 @@
+CI workflow includes a `Run tests` step before `Type check` in `.github/workflows/ci.yml`.
+Step order: Checkout -> Setup Node.js -> Install Rust stable -> Rust cache -> Install frontend dependencies -> Run tests -> Type check -> Build Tauri app.

.sisyphus/evidence/task-10-cross-platform.txt

@@ -0,0 +1,13 @@
+Task 10 cross-platform attachment contract coverage
+
+Verification:
+- Added src/__tests__/cross-platform-contract.test.ts
+- Covered desktop/web normalization into shared AttachmentRef shape
+- Covered ACP resource_link serialization for multiple attachments
+- Covered allowed and disallowed file extensions
+- Mocked @tauri-apps/plugin-fs stat to return size 2048
+- Ran npx vitest run: PASS
+
+Result:
+- 9 test files passed
+- 39 tests passed

.sisyphus/evidence/task-10-wire-format.txt

@@ -0,0 +1,10 @@
+
+ RUN  v3.2.4 D:/agi-project/acp-ui
+
+ 鉁?[39m src/__tests__/cross-platform-contract.test.ts (3 tests) 12ms
+
+ Test Files  1 passed (1)
+      Tests  3 passed (3)
+   Start at  18:04:32
+   Duration  1.65s (transform 177ms, setup 82ms, collect 138ms, tests 12ms, environment 877ms, prepare 214ms)
+

.sisyphus/evidence/task-11-picker-cancel.txt

@@ -0,0 +1,22 @@
+
+ RUN  v3.2.4 D:/agi-project/acp-ui
+
+stdout | src/__tests__/session-reset-regression.test.ts > session reset regressions > composer attachment lifecycle on send clears pending state but keeps message metadata
+Agent initialized: { agentCapabilities: { loadSession: true }, authMethods: [] }
+
+stdout | src/__tests__/session-reset-regression.test.ts > session reset regressions > composer attachment lifecycle on send clears pending state but keeps message metadata
+Prompt completed: end_turn
+
+stdout | src/__tests__/session-reset-regression.test.ts > session reset regressions > session switch clears pending attachments
+Agent initialized: { agentCapabilities: { loadSession: true }, authMethods: [] }
+
+stdout | src/__tests__/session-reset-regression.test.ts > session reset regressions > canceling picker is a no-op
+Agent initialized: { agentCapabilities: { loadSession: true }, authMethods: [] }
+
+ 鉁?[39m src/__tests__/session-reset-regression.test.ts (3 tests) 89ms
+
+ Test Files  1 passed (1)
+      Tests  3 passed (3)
+   Start at  18:03:58
+   Duration  2.77s (transform 465ms, setup 44ms, collect 658ms, tests 89ms, environment 483ms, prepare 202ms)
+

.sisyphus/evidence/task-11-session-switch.txt

@@ -0,0 +1,5 @@
+Task 11 regression evidence
+
+- Added composer reset regression tests for send, session switch, and picker cancel behavior.
+- Added minimal ChatView session-change watcher to clear pending composer state only.
+- Verification: `npx vitest run` passed (45 tests).

.sisyphus/evidence/task-12-command-agnostic.txt

@@ -0,0 +1,20 @@
+Task 12 evidence - generic attachment send behavior
+
+Audit findings:
+- ChatView handleAttach/handleSend/template contain no ingest-only branching; pending attachments are selected, validated, rendered, and sent through one generic path.
+- sessionStore.sendPrompt(text, attachments) always builds one text block plus optional serialized attachment resource_link blocks with no command-specific checks.
+- src/lib/attachments.ts and src/lib/file-picker.ts contain no ingest/command branching.
+- Platform-specific picker logic remains isolated to src/lib/file-picker.ts via the mockable _rawPicker seam.
+- No scope creep detected: no drag/drop, clipboard paste, preview thumbnails, upload progress, base64 embedding, custom Rust command, ACP extension, or upload service layer.
+
+Added test:
+- src/__tests__/integration-command-agnostic.test.ts
+- Verifies /ingest some-text, /query some-text, and plain text all use the same sendPrompt attachment path.
+- Asserts identical attachment metadata on stored user messages and identical resource_link block structure apart from the text block content itself.
+
+Verification:
+- npx vitest run -> 12 passed files, 46 passed tests
+- npx vue-tsc --noEmit -> passed
+
+Result:
+- Generic attachments are command-agnostic and flow through the existing UI/store/serialization path without special-casing.

.sisyphus/evidence/task-12-text-only-regression.txt

@@ -0,0 +1,76 @@
+
+ RUN  v3.2.4 D:/agi-project/acp-ui
+
+stdout | src/__tests__/integration-command-agnostic.test.ts > attachment flow stays command agnostic > uses the same attachment prompt structure for slash commands and plain text
+Agent initialized: { agentCapabilities: {}, authMethods: [] }
+
+stdout | src/__tests__/integration-command-agnostic.test.ts > attachment flow stays command agnostic > uses the same attachment prompt structure for slash commands and plain text
+Prompt completed: end_turn
+
+stdout | src/__tests__/integration-command-agnostic.test.ts > attachment flow stays command agnostic > uses the same attachment prompt structure for slash commands and plain text
+Agent initialized: { agentCapabilities: {}, authMethods: [] }
+
+stdout | src/__tests__/integration-command-agnostic.test.ts > attachment flow stays command agnostic > uses the same attachment prompt structure for slash commands and plain text
+Prompt completed: end_turn
+
+stdout | src/__tests__/integration-command-agnostic.test.ts > attachment flow stays command agnostic > uses the same attachment prompt structure for slash commands and plain text
+Agent initialized: { agentCapabilities: {}, authMethods: [] }
+
+stdout | src/__tests__/integration-command-agnostic.test.ts > attachment flow stays command agnostic > uses the same attachment prompt structure for slash commands and plain text
+Prompt completed: end_turn
+
+ 鉂?[39m src/__tests__/integration-command-agnostic.test.ts (1 test | 1 failed) 106ms
+   脳 attachment flow stays command agnostic > uses the same attachment prompt structure for slash commands and plain text 104ms
+     鈫?expected [ { type: 'text', 鈥?1) }, 鈥?2) ] to deeply equal [ { type: 'text', 鈥?1) }, 鈥?2) ]
+node.exe : 
+所在位置 行:1 字符: 1
++ & "C:\Program Files\nodejs/node.exe" "C:\Users\haxu\AppData\Roaming\n ...
++ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+    + CategoryInfo          : NotSpecified: (:String) [], RemoteException
+    + FullyQualifiedErrorId : NativeCommandError
+
+鈳幆鈳幆鈳幆鈳?[39m Failed Tests 1 鈳幆鈳幆鈳幆鈳?[39m
+
+ FAIL  src/__tests__/integration-command-agnostic.test.ts > attachment flow stays command a
+gnostic > uses the same attachment prompt structure for slash commands and plain text
+AssertionError: expected [ { type: 'text', 鈥?1) }, 鈥?2) ] to deeply equal [ { type: 'text', 鈥?1) }, 鈥?2) 
+]
+
+- Expected
++ Received
+
+@@ -4,15 +4,17 @@
+      "type": "text",
+    },
+    {
+      "mimeType": "text/markdown",
+      "name": "notes.md",
++     "size": 12n,
+      "type": "resource_link",
+      "uri": "file:///C%3A/docs/notes.md",
+    },
+    {
+      "mimeType": "text/csv",
+      "name": "table.csv",
++     "size": 34n,
+      "type": "resource_link",
+      "uri": "file:///C%3A/docs/table.csv",
+    },
+  ]
+
+ 鉂?[22m src/__tests__/integration-command-agnostic.test.ts:116:32
+    114| 
+    115|     expect(recordedPrompts).toHaveLength(3);
+    116|     expect(recordedPrompts[0]).toEqual([
+       |                                ^
+    117|       { type: 'text', text: '/ingest some-text' }
+[33m,
+    118|       { type: 'resource_link', uri: 'file:///C%3A/docs/notes.md', name鈥?
+鈳幆鈳幆鈳幆鈳幆鈳幆鈳幆鈳幆鈳幆鈳幆鈳幆鈳幆鈳幆[1/1]鈳?[22m
+
+
+ Test Files  1 failed (1)
+      Tests  1 failed (1)
+   Start at  18:03:59
+   Duration  2.05s (transform 134ms, setup 46ms, collect 165ms, tests 106ms, environment 513ms, prepare 233ms)
+

.sisyphus/evidence/task-2-validation-fail.txt

@@ -0,0 +1,2 @@
+FAIL: npm test
+Result: none

.sisyphus/evidence/task-2-validation-pass.txt

@@ -0,0 +1,3 @@
+PASS: npm test
+Result: 2 test files passed, 10 tests passed
+Attachment validation tests: passed

.sisyphus/evidence/task-4-serializer-edge.txt

@@ -0,0 +1,2 @@
+Windows path encoding: file:///C%3A/Users/docs/file.md
+Unicode/space encoding: file:///home/user/%E7%9F%A5%E8%AF%86%E5%BA%93%20%E6%96%87%E6%A1%A3.pdf

.sisyphus/evidence/task-4-serializer-pass.txt

@@ -0,0 +1 @@
+npm test passed: 4 files, 21 tests

.sisyphus/evidence/task-5-store-dispatch.txt

@@ -0,0 +1,30 @@
+Task 5 evidence: attachment-aware session dispatch
+
+Changed files:
+- src/stores/session.ts
+- src/lib/types.ts
+- src/__tests__/session-store.test.ts
+
+Relevant behavior:
+- sendPrompt(text, attachments?) now builds a ContentBlock[] prompt with:
+  1. { type: 'text', text }
+  2. zero-to-many serialized resource_link blocks from serializeAttachmentsToContentBlocks(attachments)
+- user messages persist attachments only when attachments.length > 0
+
+Automated proof:
+- src/__tests__/session-store.test.ts :: sends text plus attachment resource links and stores attachments metadata
+- Assertion verifies prompt payload equals:
+  [
+    { type: 'text', text: 'hello' },
+    { type: 'resource_link', uri: 'file:///path1', name: 'file1.md', mimeType: 'text/markdown' },
+    { type: 'resource_link', uri: 'file:///path2', name: 'file2.json', mimeType: 'application/json' }
+  ]
+- Assertion verifies store.messages[0].attachments equals the original attachment array
+
+Command result:
+- npm test PASS
+- Included: src/__tests__/session-store.test.ts (3 tests)
+
+Excerpt:
+- "✓ src/__tests__/session-store.test.ts (3 tests)"
+- "Tests 28 passed (28)"

.sisyphus/evidence/task-5-text-only-regression.txt

@@ -0,0 +1,25 @@
+Task 5 evidence: text-only regression coverage
+
+Regression target:
+- sendPrompt('hello') without attachments must keep prior text-only ACP prompt behavior
+- sendPrompt('hello', []) must behave the same as text-only
+
+Automated proof:
+- src/__tests__/session-store.test.ts :: sends a text-only prompt and stores no attachments metadata
+  Expected prompt:
+  [{ type: 'text', text: 'hello' }]
+  Expected user message attachments: undefined
+
+- src/__tests__/session-store.test.ts :: treats an empty attachments array like a text-only prompt
+  Expected prompt:
+  [{ type: 'text', text: 'hello' }]
+  Expected user message attachments: undefined
+
+Command result:
+- npm test PASS
+- npm run build PASS
+
+Excerpts:
+- "✓ src/__tests__/session-store.test.ts (3 tests)"
+- "Test Files 6 passed (6)"
+- "✓ built in 2.09s"

.sisyphus/evidence/task-7-invalid-selection.txt

@@ -0,0 +1,10 @@
+Validated composer rejection handling for invalid attachment selections.
+
+Results:
+- Disallowed files are filtered out with visible feedback.
+- Rejection messages render in the composer area.
+- Valid attachments remain available alongside rejections.
+
+Verification:
+- npm test ✅
+- npm run build ✅

.sisyphus/evidence/task-7-state-preservation.txt

@@ -0,0 +1,10 @@
+Validated pending attachment state preservation during invalid selections.
+
+Results:
+- Existing valid pending attachments survive later invalid picks.
+- Duplicate and over-count cases are rejected without clearing valid chips.
+- Composer feedback remains generic and composable.
+
+Verification:
+- npm test ✅
+- npm run build ✅

.sisyphus/evidence/task-8-history-persist.txt

@@ -0,0 +1,13 @@
+Verified with tests that sent user messages retain attachment metadata in store state after composer reset.
+
+Coverage:
+- user messages keep attachments metadata after sendPrompt
+- composer pending attachments are cleared before async send
+- message history remains metadata-only
+
+Commands:
+- npm test
+- npm run build
+
+Result:
+- PASS

.sisyphus/evidence/task-8-metadata-only.txt

@@ -0,0 +1,12 @@
+Verified message history stores attachment metadata only.
+
+Checks:
+- no fileContent field on message objects
+- no body field on message objects
+- no data field on message objects
+- no base64 field on message objects
+- no blob field on message objects
+- attachment entries contain only id, name, path, mimeType, size, source
+
+Result:
+- PASS

.sisyphus/evidence/task-9-no-content-preview.txt

@@ -0,0 +1,10 @@
+
+ RUN  v3.2.4 D:/agi-project/acp-ui
+
+ 鉁?[39m src/__tests__/chatview-history-attachments.test.ts (3 tests) 61ms
+
+ Test Files  1 passed (1)
+      Tests  3 passed (3)
+   Start at  18:03:58
+   Duration  2.43s (transform 391ms, setup 35ms, collect 676ms, tests 61ms, environment 885ms, prepare 397ms)
+

.sisyphus/notepads/acp-ui-composer-attachments/learnings.md

@@ -0,0 +1,4 @@
+## 2026-04-12
+- ChatView needs a minimal watcher on `sessionStore.currentSession` to clear only composer-local pending state.
+- Pending composer attachments should reset on send and on session transitions, but sent message attachment metadata must remain in the store.
+- Canceling the file picker returns an empty selection path and should leave composer state untouched.