Migrate flyteconnector chart wiring and runtime defaults for Flyte Connectors#7377
Draft
kevinliao852 wants to merge 4 commits into
Draft
Migrate flyteconnector chart wiring and runtime defaults for Flyte Connectors#7377kevinliao852 wants to merge 4 commits into
kevinliao852 wants to merge 4 commits into
Conversation
Signed-off-by: Kevin Liao <q85292542000@gmail.com>
- Added `flyteconnector` as a dependency in `Chart.yaml`. - Updated image repository and tag in `flyteconnector` README and `values.yaml` to use the latest version from GitHub. Signed-off-by: Kevin Liao <q85292542000@gmail.com>
…efaults Signed-off-by: Kevin Liao <q85292542000@gmail.com>
Signed-off-by: Kevin Liao <q85292542000@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the flyteconnector Helm chart to the new Flyte Connectors runtime and wires it into flyte-binary as a real Helm subchart dependency. It updates the connector image to ghcr.io/flyteorg/flyte-connectors:latest, switches the container command to flyte serve connector, fixes additionalVolumeMounts rendering, and clears the showcase secret data from the chart defaults.
Changes:
- Add
flyteconnectoras afile://-based subchart dependency offlyte-binary(gated byflyteconnector.enabled). - Update connector image, tag, and startup command in the chart's deployment template and defaults.
- Empty out
connectorSecret.secretDataand adjust template indentation so additional volume mounts render correctly.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/flyte-binary/Chart.yaml | Adds the flyteconnector subchart as a conditional Helm dependency. |
| charts/flyteconnector/Chart.yaml | New chart manifest (v0.1.10). |
| charts/flyteconnector/.helmignore | Standard helm ignore patterns for the new chart. |
| charts/flyteconnector/README.md | Auto-generated values reference for the new chart. |
| charts/flyteconnector/values.yaml | New default values: image, ports, RBAC, probes, service, etc. |
| charts/flyteconnector/templates/_helpers.tpl | Helper templates for names, labels, secret volume/mount, service port. |
| charts/flyteconnector/templates/connector/deployment.yaml | Connector Deployment with flyte serve connector command and fixed volume-mount rendering. |
| charts/flyteconnector/templates/connector/service.yaml | gRPC ClusterIP Service for the connector. |
| charts/flyteconnector/templates/connector/serviceaccount.yaml | Optional ServiceAccount with annotations and imagePullSecrets. |
| charts/flyteconnector/templates/connector/secret.yaml | Opaque Secret pseudo-manifest fed by connectorSecret.secretData. |
| charts/flyteconnector/templates/connector/rbac.yaml | Optional ClusterRole/ClusterRoleBinding for cross-namespace secret reads. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,102 @@ | |||
| # --------------------------------------------------------------------- | |||
| # FLYTE_CONNCETOR SETTINGS | |||
| additionalContainers: [] | ||
| # -- Appends extra command line arguments to the main command | ||
| extraArgs: {} | ||
| # -- Sets priorityClassName for datacatalog pod(s). |
| {{- end }} | ||
|
|
||
| {{- define "flyteconnector.servicePort" -}} | ||
| {{ include .Values.ports.containerPort}} |
Comment on lines
+40
to
+41
| # -- Default regex string for searching configuration files | ||
| configPath: /etc/flyteconnector/config/*.yaml |
Comment on lines
+9
to
+12
| # commonLabels Add labels to all the deployed resources | ||
| commonLabels: {} | ||
| # commonAnnotations Add annotations to all the deployed resources | ||
| commonAnnotations: {} |
| # -- Docker image for flyteconnector deployment | ||
| repository: ghcr.io/flyteorg/flyte-connectors # FLYTECONNECTOR_IMAGE | ||
| # -- Docker image tag | ||
| tag: latest # FLYTECONNECTOR_TAG |
Comment on lines
+1
to
+7
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: {{ template "flyteconnector.name" . }} | ||
| namespace: {{ template "flyte.namespace" . }} | ||
| type: Opaque | ||
| {{- with .Values.connectorSecret.secretData -}} |
Comment on lines
+11
to
+15
| {{- end}} | ||
| {{- with .Values.serviceAccount.imagePullSecrets }} | ||
| imagePullSecrets: {{ tpl (toYaml .) $ | nindent 2 }} | ||
| {{- end }} | ||
| {{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
This PR completes the first pass of the flyteconnector chart migration to the new Flyte Connectors image/runtime.
What changes were proposed in this pull request?
pyflyte serve agentto the verified runtime commandflyte serve connectorHow was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Stack
If you do use
git townto manage PR Stacks, the stack relevant to this PRwill show below. Otherwise, you can ignore this section.
Docs link