Add support for specifying anonymous/public paths for apps#7354
Draft
jeevb wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Flyte “App” IDL to allow specifying a list of anonymous/public URL paths on an app’s SecurityContext, enabling partial unauthenticated access without making the entire app public.
Changes:
- Added
anonymous_pathstoSecurityContextinflyteidl2/app/app_definition.protowith buf.validate constraints. - Regenerated TypeScript, Python, and Go protobuf outputs to include the new field (struct/type updates, descriptors).
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
flyteidl2/app/app_definition.proto |
Introduces anonymous_paths field on SecurityContext with validation annotations and documentation. |
gen/go/flyteidl2/app/app_definition.pb.go |
Updates Go protobuf struct/accessors and raw descriptor to include AnonymousPaths. |
gen/python/flyteidl2/app/app_definition_pb2.py |
Updates Python generated descriptor/options to include anonymous_paths. |
gen/python/flyteidl2/app/app_definition_pb2.pyi |
Updates Python typing stubs for the new anonymous_paths field. |
gen/ts/flyteidl2/app/app_definition_pb.ts |
Updates TS generated types/descriptors to include anonymousPaths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+365
to
+369
| repeated string anonymous_paths = 6 [ | ||
| (buf.validate.field).repeated.max_items = 50, | ||
| (buf.validate.field).repeated.items.string.min_len = 1, | ||
| (buf.validate.field).repeated.items.string.pattern = "^/.*" | ||
| ]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Stack
If you do use
git townto manage PR Stacks, the stack relevant to this PRwill show below. Otherwise, you can ignore this section.
Docs link