feat(tfctl): add --all flag to 'reconcile' command for bulk reconciliation#1744
feat(tfctl): add --all flag to 'reconcile' command for bulk reconciliation#1744cschindlbeck wants to merge 6 commits into
Conversation
Adds --all / -A to tfctl reconcile for bulk resource reconciliation
|
Looks fine to me, but I don't have permissions to approve in this repo |
|
Thank you for the contribution! It looks like we've got a few vulnerabilities which are blocking the pipeline - I'll get these cleared up and then review this. |
|
@alexandermarston thanks a bunch, can you decide if we should include commit f2dfa70 or remove, that means, should the -A flag be included, this would be consistent with the other commands, i would revert it then |
|
If we are just trying to trigger a bulk reconciliation, could we consider doing something like this? (fyi, this is what we use internally at my org) I prefer this way as I don't have to wait for the What are your thoughts? Perhaps we can add this to the docs. |
|
But it we already have |
|
@alexandermarston From my perspective, the goal of this PR was to make tfctl reconcile consistent with other commands like suspend/resume, which already support bulk operations via flags. We can add your suggestion to the docs too in case of someone wants to skip the Reconcile requested. Or add another flag --skip-reconcile |
Adds --all to tfctl reconcile for bulk resource reconciliation