feat(runner-config): ✨ override image pull policy default value#1422
Open
yroffin wants to merge 4 commits into
Open
feat(runner-config): ✨ override image pull policy default value#1422yroffin wants to merge 4 commits into
yroffin wants to merge 4 commits into
Conversation
yroffin
changed the title
yroffin
changed the title
yroffin
force-pushed
the
setup-runner-img-pull-policy
branch
from
e4ac25b to
d60ffff
Compare
akselleirv
reviewed
Sep 15, 2024
akselleirv
left a comment
akselleirv
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the feature and the test! Added some suggestions.
Collaborator
|
Can you please rebase on main after #1439 has been merged? That should fix the pipeline errors. |
Co-authored-by: Aksel Skaar Leirvaag <52233080+akselleirv@users.noreply.github.com>
Co-authored-by: Aksel Skaar Leirvaag <52233080+akselleirv@users.noreply.github.com>
yroffin
force-pushed
the
setup-runner-img-pull-policy
branch
from
e510ca1 to
3f2a192
Compare
Author
|
@akselleirv job is done, i've rebase my pull request and take in account your propositions |
Collaborator
|
Thanks @yroffin ! Last thing, can you please run make manifests again to generate the CRD. |
Author
|
@akselleirv job done, do you think it will be store in next milestone ? on my project i will be happy to have this feature |
Collaborator
|
@yroffin can you please the pipeline https://github.com/flux-iac/tofu-controller/actions/runs/10917321807/job/30326377700?pr=1422 ? Regarding a new release, it depends on a follow up in issue #1234 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default imagePullPolicy is set to v1.PullIfNotPresent and imagePullPolicy don't exist in CRD
target of this pull request is to add imagePullPolicy in CRD and use it to override default PullIfNotPresent value