Skip to content

docs: installation: linux: redhat-centos: fix broken yum repo example#2563

Merged
eschabell merged 1 commit intofluent:masterfrom
eschabell:erics_yum_repo_example_fix
May 3, 2026
Merged

docs: installation: linux: redhat-centos: fix broken yum repo example#2563
eschabell merged 1 commit intofluent:masterfrom
eschabell:erics_yum_repo_example_fix

Conversation

@eschabell
Copy link
Copy Markdown
Collaborator

@eschabell eschabell commented May 2, 2026

The .repo file examples had two-space indentation on every key, which
yum/dnf interprets as continuation lines, causing "failed loading
/etc/yum.repos.d/fluent-bit.repo, skipping". Removed the indentation,
added the missing $basearch to the primary baseurl, and normalized to
key=value format across all three examples in the page.

Fixes #2553

Summary by CodeRabbit

  • Documentation
    • Updated Yum repository configuration examples and guidance for Red Hat/CentOS installations to improve accuracy and clarity.
    • Enhanced troubleshooting section with corrected repository URL configuration instructions.

  The .repo file examples had two-space indentation on every key, which
  yum/dnf interprets as continuation lines, causing "failed loading
  /etc/yum.repos.d/fluent-bit.repo, skipping". Removed the indentation,
  added the missing $basearch to the primary baseurl, and normalized to
  key=value format across all three examples in the page.

  Fixes fluent#2553

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell requested a review from cosmo0920 May 2, 2026 08:28
@eschabell eschabell self-assigned this May 2, 2026
@eschabell eschabell requested a review from a team as a code owner May 2, 2026 08:28
@eschabell eschabell added waiting-on-review Waiting on a review from mainteners 5.0.4 labels May 2, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d6c13335-3bab-4cdd-8b52-9c8e95ee79f4

📥 Commits

Reviewing files that changed from the base of the PR and between 707fe9e and 3657a2a.

📒 Files selected for processing (1)
  • installation/downloads/linux/redhat-centos.md

📝 Walkthrough

Walkthrough

Red Hat/CentOS Fluent Bit installation documentation was corrected to fix broken Yum repository configuration syntax by removing invalid spaces around = operators in INI-format entries and standardizing the baseurl to include both $releasever and $basearch variables for proper package resolution.

Changes

Repository Configuration Syntax Fixes

Layer / File(s) Summary
Main Repository Setup
installation/downloads/linux/redhat-centos.md (lines 44–51)
The primary fluent-bit.repo example updated to use baseurl=https://packages.fluentbit.io/centos/$releasever/$basearch/ with corrected INI syntax (name=Fluent Bit without spaces around =).
FAQ Troubleshooting Initial Guidance
installation/downloads/linux/redhat-centos.md (lines 94–97)
The "404 - Page not found" section simplified to show only essential fields (name and baseurl with $releasever/$basearch).
Detailed Troubleshooting Example
installation/downloads/linux/redhat-centos.md (lines 105–111)
The "replace $releasever" example expanded with explicit OS release version (centos/7/$basearch/) and signing/enablement fields (gpgcheck, gpgkey, repo_gpgcheck, enabled) in corrected INI syntax.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested labels

5.0

Suggested reviewers

  • cosmo0920
  • patrick-stephens

Poem

🐰 With spaces removed from repo lines so neat,
The Yum parser now dances to the proper beat!
$releasever and $basearch align just right,
Fluent Bit installation now works at first sight. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing a broken yum repository example in the Red Hat/CentOS installation documentation.
Linked Issues check ✅ Passed The PR addresses issue #2553 by removing indentation from .repo file examples, adding missing $basearch to baseurl, and normalizing all examples to key=value format, which resolves the yum/dnf parsing errors.
Out of Scope Changes check ✅ Passed All changes are directly related to fixing the yum repository configuration examples as specified in issue #2553; no out-of-scope modifications are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@eschabell
Copy link
Copy Markdown
Collaborator Author

@cosmo0920 ready for review!

@eschabell eschabell merged commit 37f0632 into fluent:master May 3, 2026
8 checks passed
@eschabell eschabell removed the waiting-on-review Waiting on a review from mainteners label May 3, 2026
@eschabell eschabell deleted the erics_yum_repo_example_fix branch May 4, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fluent Bit repo syntax is broken.

2 participants