docs: admin: Storage backlog mem limit fixes#2561
Conversation
…limit description
- Rewrite the description to scope the setting to the storage_backlog
input plugin
- Note explicitly that it doesn't cap memory used by other filesystem-
buffering inputs
Applies to fluent#2555.
Signed-off-by: Eric D. Schabell <eric@schabell.org>
…t from storage.max_chunks_up
- Rename the heading to "Set storage.max_chunks_up in global settings"
and rewrite the paragraph to describe only that setting
- Add a new "Tune storage.backlog.mem_limit for the backlog plugin"
subsection clarifying its actual scope
- Update the storage.pause_on_chunks_overlimit subsection to reference
storage.max_chunks_up only
Applies to fluent#2555
Signed-off-by: Eric D. Schabell <eric@schabell.org>
📝 WalkthroughWalkthroughDocumentation clarifies that Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
administration/configuring-fluent-bit/yaml/service-section.md (1)
48-48: ⚡ Quick winConsider rephrasing for improved clarity.
The sentence "While the up chunks owned by
storage_backlogconsume less memory than this limit, Fluent Bit continues to promote additional backlog chunks" uses a structure that could be clearer. The word "While" typically introduces a contrast, but here it describes a condition for continuation.Consider rephrasing to make the causal relationship more explicit:
"Fluent Bit continues to promote additional backlog chunks as long as the up chunks owned by
storage_backlogconsume less memory than this limit."This alternative phrasing more clearly conveys that promotion continues because (or as long as) memory consumption is below the limit.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@administration/configuring-fluent-bit/yaml/service-section.md` at line 48, Update the wording for the storage.backlog.mem_limit description: replace the sentence beginning "While the up chunks owned by `storage_backlog` consume less memory than this limit, Fluent Bit continues to promote additional backlog chunks" with a clearer causal phrasing such as "Fluent Bit continues to promote additional backlog chunks as long as the up chunks owned by `storage_backlog` consume less memory than this limit," ensuring you keep references to `storage.backlog.mem_limit`, `storage_backlog`, and Fluent Bit intact.administration/backpressure.md (1)
73-73: ⚡ Quick winConsider rephrasing for improved clarity.
The sentence "While the up chunks owned by
storage_backlogconsume less memory than this limit, Fluent Bit continues to promote additional backlog chunks" uses the same awkward phrasing as inservice-section.md.For consistency and clarity across both files, consider the same rephrasing:
"Fluent Bit continues to promote additional backlog chunks as long as the up chunks owned by
storage_backlogconsume less memory than this limit."🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@administration/backpressure.md` at line 73, Rephrase the awkward sentence about promotion logic to match the suggested wording: replace the sentence that currently reads "While the up chunks owned by `storage_backlog` consume less memory than this limit, Fluent Bit continues to promote additional backlog chunks" with "Fluent Bit continues to promote additional backlog chunks as long as the up chunks owned by `storage_backlog` consume less memory than this limit." Keep references to `storage.backlog.mem_limit` and the `storage_backlog` input plugin intact for clarity and consistency with service-section.md.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@administration/backpressure.md`:
- Line 73: Rephrase the awkward sentence about promotion logic to match the
suggested wording: replace the sentence that currently reads "While the up
chunks owned by `storage_backlog` consume less memory than this limit, Fluent
Bit continues to promote additional backlog chunks" with "Fluent Bit continues
to promote additional backlog chunks as long as the up chunks owned by
`storage_backlog` consume less memory than this limit." Keep references to
`storage.backlog.mem_limit` and the `storage_backlog` input plugin intact for
clarity and consistency with service-section.md.
In `@administration/configuring-fluent-bit/yaml/service-section.md`:
- Line 48: Update the wording for the storage.backlog.mem_limit description:
replace the sentence beginning "While the up chunks owned by `storage_backlog`
consume less memory than this limit, Fluent Bit continues to promote additional
backlog chunks" with a clearer causal phrasing such as "Fluent Bit continues to
promote additional backlog chunks as long as the up chunks owned by
`storage_backlog` consume less memory than this limit," ensuring you keep
references to `storage.backlog.mem_limit`, `storage_backlog`, and Fluent Bit
intact.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 890c2694-7cab-4e04-890c-7c1f1c5116ba
📒 Files selected for processing (2)
administration/backpressure.mdadministration/configuring-fluent-bit/yaml/service-section.md
docs: administration: backpressure: separate storage.backlog.mem_limit from storage.max_chunks_up
docs: administration: yaml: service-section: fix storage.backlog.mem_limit description
Fixes #2555.
Summary by CodeRabbit
Release Notes
storage.max_chunks_upandstorage.backlog.mem_limitconfiguration options