Skip to content

feat: add --verbose flag to Claude invocation for observability#19

Merged
adalton merged 1 commit into
flightctl:masterfrom
ItzikEzra-rh:osac-797-stream-json-verbose
May 14, 2026
Merged

feat: add --verbose flag to Claude invocation for observability#19
adalton merged 1 commit into
flightctl:masterfrom
ItzikEzra-rh:osac-797-stream-json-verbose

Conversation

@ItzikEzra-rh
Copy link
Copy Markdown

Adds --verbose to the Claude CLI command so detailed progress (tool calls, thinking, phase transitions) goes to stderr, which is already captured to session.log via the existing tee on line 48.

No change to stdout or the cli-output.json parsing.

Jira: https://redhat.atlassian.net/browse/OSAC-797

…-797)

Adds --verbose so Claude sends detailed progress to stderr (tool calls,
thinking, phase transitions). stderr is already captured to session.log
via the existing tee. No change to stdout/json parsing.

Jira: https://redhat.atlassian.net/browse/OSAC-797
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 10, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 525ee03a-7b70-4dff-81ab-b1d3bcd9e011

📥 Commits

Reviewing files that changed from the base of the PR and between 07decbd and 08a421e.

📒 Files selected for processing (1)
  • executor/script.go

Summary by CodeRabbit

  • New Features
    • Verbose output is now enabled during command execution, providing more detailed logging information to users.

Walkthrough

The buildClaudeCommand function in executor/script.go now includes the --verbose flag when constructing Claude CLI invocations. This single-line change adds verbose output to the command without altering the rest of the command construction logic or parameter handling.

Changes

Verbose Claude CLI Output

Layer / File(s) Summary
CLI Command Configuration
executor/script.go
buildClaudeCommand adds --verbose flag to base claude CLI arguments for expanded command output.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding the --verbose flag to Claude invocation for observability purposes.
Description check ✅ Passed The description is directly related to the changeset, explaining why the --verbose flag was added and how it integrates with existing logging infrastructure.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@adalton adalton self-requested a review May 11, 2026 13:36
@adalton adalton merged commit 32b71f5 into flightctl:master May 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants