Skip to content

EDM-3387: Allow editing default alias#638

Merged
celdrake merged 1 commit into
flightctl:mainfrom
celdrake:EDM-3387-allow-editing-default-alias
May 11, 2026
Merged

EDM-3387: Allow editing default alias#638
celdrake merged 1 commit into
flightctl:mainfrom
celdrake:EDM-3387-allow-editing-default-alias

Conversation

@celdrake
Copy link
Copy Markdown
Collaborator

Now that it's possible for users to provide different default labels, UI should also allow them to modify the "defaultAlias" label.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 7d82a43d-c238-444d-bb2b-3e24a17b3c23

📥 Commits

Reviewing files that changed from the base of the PR and between 2ef7f48 and 4938fb5.

📒 Files selected for processing (1)
  • libs/ui-components/src/components/modals/ApproveDeviceModal/ApproveDeviceForm.tsx
💤 Files with no reviewable changes (1)
  • libs/ui-components/src/components/modals/ApproveDeviceModal/ApproveDeviceForm.tsx

Summary by CodeRabbit

  • Bug Fixes
    • The device alias field in the approval process is now always enabled, allowing unrestricted editing of the device alias during the approval workflow.

Walkthrough

The PR removes conditional disabling logic from the device alias field in the device approval form, allowing the field to always be editable regardless of whether a default alias exists in the enrollment request.

Changes

Device Alias Field Enablement

Layer / File(s) Summary
Alias Field Behavior
libs/ui-components/src/components/modals/ApproveDeviceModal/ApproveDeviceForm.tsx
The deviceAlias RichValidationTextField is rendered without the isDisabled prop that previously prevented editing when enrollmentRequest.spec.labels?.alias was present.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: allowing users to edit the default alias field, which directly matches the code change removing the disabled state.
Description check ✅ Passed The description directly relates to the changeset, explaining the business context for why the alias field should now be editable.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@celdrake celdrake merged commit 6d08224 into flightctl:main May 11, 2026
10 checks passed
@celdrake celdrake deleted the EDM-3387-allow-editing-default-alias branch May 11, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants