-
Notifications
You must be signed in to change notification settings - Fork 23
EDM-3715 vulnerability management #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
celdrake
merged 7 commits into
flightctl:main
from
celdrake:EDM-3715-vulnerability-management
May 15, 2026
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ef848d2
EDM-3715: Vulnerability management
celdrake af0eacb
Code review comments
celdrake 5969128
Add new types for link and issuer
celdrake 995cf59
EDM-3715: Add links according to new API fields
celdrake 5412e0a
Update colors until we get proper UX guidance
celdrake b2948f1
Improve code after code review
celdrake f6911d8
Grid item and better responsiveness for vuln summary
celdrake File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
apps/ocp-plugin/src/components/SecurityOverview/SecurityOverviewPage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import * as React from 'react'; | ||
| import SecurityOverviewPage from '@flightctl/ui-components/src/components/SecurityOverview/SecurityOverviewPage'; | ||
| import WithPageLayout from '../common/WithPageLayout'; | ||
|
|
||
| const OcpSecurityOverviewPage = () => { | ||
| return ( | ||
| <WithPageLayout> | ||
| <SecurityOverviewPage /> | ||
| </WithPageLayout> | ||
| ); | ||
| }; | ||
|
|
||
| export default OcpSecurityOverviewPage; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing 401 handling for vulnerability responses.
Unlike
handleApiJSONResponse(which callsredirectToLogin()on 401) andhandleAlertsJSONResponse(which treats 401 as "disabled"),handleVulnerabilityJSONResponsehas no explicit 401 handling. This means unauthorized requests to vulnerability endpoints will throw a generic error instead of redirecting users to login.🔧 Proposed fix to add 401 handling
const handleVulnerabilityJSONResponse = async <R>(response: Response): Promise<R> => { if (response.ok) { const data = (await response.json()) as R; return data; } if (response.status === 404) { throw new Error(`Error ${response.status}: ${response.statusText}`); } + if (response.status === 401) { + redirectToLogin(); + } + // API returns 501 for disabled vulnerabilities API. if (response.status === 501) { throw new Error(`${response.status}`); } throw new Error(await getErrorMsgFromApiResponse(response)); };📝 Committable suggestion
🤖 Prompt for AI Agents