Skip to content

Fix duplicate 'about' in report collection checkback message #45108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kilo-code-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix duplicate 'about' in report collection checkback message #45108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/pages/queries/details/components/NoResults/NoResults.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,15 @@
// Converts seconds takes to update to human readable format
const readableCheckbackTime = formatDistance(
add(new Date(), { seconds: secondsCheckbackTime() }),
new Date()
new Date(),

Check failure on line 43 in frontend/pages/queries/details/components/NoResults/NoResults.tsx

View workflow job for this annotation

GitHub Actions / lint-js (ubuntu-latest) 

Delete `,`
);

// Collecting results state only shows if caching is enabled
if (collectingResults && !disabledCaching) {
const collectingResultsInfo = () => (
<>
Fleet is collecting report results. <br />
Check back in about {readableCheckbackTime}.
Check back in {readableCheckbackTime}.
Copy link
Copy Markdown
Member

@mikermcneil mikermcneil May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? readableCheckbackTime already includes "about": https://github.com/date-fns/date-fns/blob/dd66398305c2b015fba3c1b3d31ccff42ee8d4cf/src/formatDistance/index.ts#L31-L49

Copy link
Copy Markdown
Member

@mikermcneil mikermcneil May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Copy Markdown

@MikeWilkes-Aikido MikeWilkes-Aikido May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

</>
);

Expand Down
Loading