Remove unused OpenCV dependency from test build#88
Open
jeffdaily wants to merge 1 commit into
Open
Conversation
The sgm-test target requires OpenCV via find_package(OpenCV REQUIRED) and
links ${OpenCV_LIBS}, but no test source includes an OpenCV header or
references any cv:: symbol -- the tests build their inputs synthetically
and compare GPU output against a CPU reference. The dependency is
vestigial (carried over from the sample programs, which do use OpenCV).
Requiring OpenCV forces it to be installed to configure and build the
tests on any platform, even though it contributes nothing to them. Drop
the find_package(OpenCV) call and the ${OpenCV_INCLUDE_DIRS} /
${OpenCV_LIBS} references from the test target so the tests build with
just CUDA and the SGM library.
This work was done with assistance from Claude (Anthropic).
jeffdaily
added a commit
to jeffdaily/moat
that referenced
this pull request
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sgm-testtarget requires OpenCV viafind_package(OpenCV REQUIRED)and links${OpenCV_LIBS}, but no test source includes an OpenCV header or references anycv::symbol -- the tests build their inputs synthetically and compare GPU output against a CPU reference. The dependency is vestigial (carried over from the sample programs, which do use OpenCV).Requiring OpenCV forces it to be installed to configure and build the tests on any platform, even though it contributes nothing to them. This drops the
find_package(OpenCV)call and the${OpenCV_INCLUDE_DIRS}/${OpenCV_LIBS}references from the test target so the tests build with just CUDA and the SGM library.This work was done with assistance from Claude (Anthropic).