added Dutch translation and minor improvements#386
Conversation
|
closes #109 |
erciccione
left a comment
erciccione
left a comment
There was a problem hiding this comment.
Thank you for taking the time to do this :)
- Please add
nlto thelanguagesentry in_config.ymlso that it will result:
languages: ["en", "zh-cn", "id", "nl"]
- We need a Dutch speaker to review the translated strings.
PanderMusubi
force-pushed
the
dutchtranslation
branch
2 times, most recently
from
793b0d6 to
56c5e09
Compare
|
I have a friend of mine review the translation. Other question, do we have a testing/staging environment for the website so the translation can be viewed in the resulting website? This would also be beneficial for more translations that will be added in the future or major changes which influence translations. |
|
@PanderMusubi We are still trying to decide in #329. A CI file already exists, but does not generate previews at the moment. |
|
You can also run the website locally. See https://jekyllrb.com/docs/ |
PanderMusubi
force-pushed
the
dutchtranslation
branch
from
56c5e09 to
563f718
Compare
Thanks, see also #389 |
PanderMusubi
force-pushed
the
dutchtranslation
branch
from
563f718 to
d627981
Compare
erciccione
left a comment
erciccione
left a comment
There was a problem hiding this comment.
Technically ok, but would be better to have somebody review the translations.
|
Perhaps find somebody via Discord? |
erciccione
left a comment
erciccione
left a comment
There was a problem hiding this comment.
These suggestions come from a native Dutch speaker. I'm posting for them, but i do not speak the language.
Co-authored-by: ErC <erciccione@users.noreply.github.com>
Co-authored-by: ErC <erciccione@users.noreply.github.com>
|
I've processed the feedback. Thanks. |
erciccione
left a comment
erciccione
left a comment
There was a problem hiding this comment.
Just a minor fix and then looks ready for merge
* added Dutch translation and minor improvements * Update _i18n/nl.yml Co-authored-by: ErC <erciccione@users.noreply.github.com> * Update _i18n/nl.yml Co-authored-by: ErC <erciccione@users.noreply.github.com> * remove empty lines --------- Co-authored-by: ErC <erciccione@users.noreply.github.com>
3 participants
No description provided.