Skip to content

doc: add deployment section to README#145

Merged
demolaf merged 3 commits intomainfrom
deployment-docs
Apr 20, 2026
Merged

doc: add deployment section to README#145
demolaf merged 3 commits intomainfrom
deployment-docs

Conversation

@demolaf
Copy link
Copy Markdown
Member

@demolaf demolaf commented Apr 17, 2026

Closes #12

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md to include a new "Deployment" section in both the table of contents and the main body, providing links to external documentation and clarifying production support for HTTPS triggers. A review comment suggests improving the consistency of the documentation by adding onCallWithData to the list of supported triggers and using the [!NOTE] syntax for better formatting.

Comment thread README.md Outdated
@demolaf demolaf requested a review from Lyokone April 17, 2026 14:58
@demolaf demolaf merged commit ccd535a into main Apr 20, 2026
9 checks passed
@demolaf demolaf deleted the deployment-docs branch April 20, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update README for deploy the firebase functions

2 participants