Update go-data-transfer to v2.0.0-rc1#15
Merged
Conversation
hannahhoward
approved these changes
Jan 5, 2023
hannahhoward
left a comment
hannahhoward
left a comment
Collaborator
There was a problem hiding this comment.
LGTM I think -- the changes to retrieval code were largely from my side right?
Contributor
Author
Yeah, I took everything related to the VoucherType and BindNode.RegisterType stuff. I kept all of Lassie's go-state-types usage since the original PR still used the Lotus dependencies. The structure of it all was relatively the same except for the changes that required VoucherTypes. |
Collaborator
|
Sounds good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the filecoin-project/go-data-transfer dependency to v2.0.0-rc1 following a similar but unmerged PR for the same in application-research/filclient. That PR was blocked due to it's Lotus dependencies. Lassie is no longer dependent on Lotus and can therefore update it's dependencies without being blocked.
Modules intentionally changed:
Removed github.com/filecoin-project/go-data-transfer v1.15.2
Added github.com/filecoin-project/go-data-transfer/v2 v2.0.0-rc1
Added github.com/filecoin-project/go-fil-markets v1.24.3-0.20221014045531-68279a837f6a
Resolves issue #3