Skip to content

feat(skin): inverse-distance auto skin weights (closes #402) #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fernandotonon merged 6 commits into from
Jun 1, 2026

fix(skin): address CodeRabbit review on PR #699

2910c19
Select commit
Loading
Failed to load commit list.
Merged

feat(skin): inverse-distance auto skin weights (closes #402) #699

fix(skin): address CodeRabbit review on PR #699
2910c19
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 1, 2026 in 2m 7s

Quality Gate passed

Issues
52 New issues
0 Accepted issues

Measures
0 Security Hotspots
22.0% Coverage on New Code
4.1% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 6876 in src/CLIPipeline.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 52 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ521-piGzJsVDTR9PLP&open=AZ521-piGzJsVDTR9PLP&pullRequest=699

Check warning on line 134 in src/SkinWeights.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "std::array" or "std::vector" instead of a C-style array. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ521-jyGzJsVDTR9PKx&open=AZ521-jyGzJsVDTR9PKx&pullRequest=699

Check failure on line 1483 in src/MCPServer.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 27 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ6BxhfnruaWr7q7Z3tu&open=AZ6BxhfnruaWr7q7Z3tu&pullRequest=699

Check warning on line 226 in src/SkinWeights.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "numChildren" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ521-naGzJsVDTR9PLB&open=AZ521-naGzJsVDTR9PLB&pullRequest=699

Check failure on line 231 in src/SkinWeights.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ521-naGzJsVDTR9PLE&open=AZ521-naGzJsVDTR9PLE&pullRequest=699

Check failure on line 396 in src/SkinWeights.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ6BnpsyGAWD_diYbs_o&open=AZ6BnpsyGAWD_diYbs_o&pullRequest=699

Check warning on line 45 in src/SkinWeightsController.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "first" is "class Ogre::Entity *". 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ521-luGzJsVDTR9PK4&open=AZ521-luGzJsVDTR9PK4&pullRequest=699

Check warning on line 218 in src/SkinWeights.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "bone" is "class Ogre::Bone *". 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ521-naGzJsVDTR9PLI&open=AZ521-naGzJsVDTR9PLI&pullRequest=699

Check failure on line 200 in src/SkinWeights.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ521-naGzJsVDTR9PLD&open=AZ521-naGzJsVDTR9PLD&pullRequest=699

Check warning on line 289 in src/SkinWeights.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the redundant return type of this lambda. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ6BnpsyGAWD_diYbs_d&open=AZ6BnpsyGAWD_diYbs_d&pullRequest=699

Check warning on line 6987 in src/CLIPipeline.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "node" is "class Ogre::SceneNode *". 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ521-piGzJsVDTR9PLS&open=AZ521-piGzJsVDTR9PLS&pullRequest=699

Check warning on line 410 in src/SkinWeights.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Modify the macro definition so that it needs to be followed by a semicolon, or remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ6BnpsyGAWD_diYbs_Z&open=AZ6BnpsyGAWD_diYbs_Z&pullRequest=699

Check warning on line 284 in src/SkinWeights.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 42 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ6BnpsyGAWD_diYbs_e&open=AZ6BnpsyGAWD_diYbs_e&pullRequest=699

Check warning on line 249 in src/SkinWeights.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto". 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ521-naGzJsVDTR9PLL&open=AZ521-naGzJsVDTR9PLL&pullRequest=699

Check warning on line 104 in src/SkinWeights.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define each identifier in a dedicated statement. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ521-naGzJsVDTR9PK_&open=AZ521-naGzJsVDTR9PK_&pullRequest=699

Check warning on line 380 in src/SkinWeights.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'const unsigned short' 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ521-naGzJsVDTR9PK8&open=AZ521-naGzJsVDTR9PK8&pullRequest=699

Check failure on line 15 in src/SkinWeightsController.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ521-luGzJsVDTR9PKz&open=AZ521-luGzJsVDTR9PKz&pullRequest=699

Check failure on line 164 in src/SkinWeights.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 89 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ521-naGzJsVDTR9PLC&open=AZ521-naGzJsVDTR9PLC&pullRequest=699

Check warning on line 391 in src/SkinWeights.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid this unnecessary copy by using a "const" reference. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ6BnpsyGAWD_diYbs_m&open=AZ6BnpsyGAWD_diYbs_m&pullRequest=699

Check failure on line 365 in src/SkinWeights.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ6BnpsyGAWD_diYbs_l&open=AZ6BnpsyGAWD_diYbs_l&pullRequest=699

Check warning on line 255 in src/SkinWeights.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the redundant return type of this lambda. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ6BnpsyGAWD_diYbs_a&open=AZ6BnpsyGAWD_diYbs_a&pullRequest=699

Check warning on line 309 in src/SkinWeights.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this declaration by a structured binding declaration. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ6BnpsyGAWD_diYbs_i&open=AZ6BnpsyGAWD_diYbs_i&pullRequest=699

Check warning on line 6888 in src/CLIPipeline.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this loop so that it is less error-prone. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ521-piGzJsVDTR9PLR&open=AZ521-piGzJsVDTR9PLR&pullRequest=699

Check warning on line 254 in src/SkinWeights.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 21 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function. 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ6BnpsyGAWD_diYbs_b&open=AZ6BnpsyGAWD_diYbs_b&pullRequest=699

Check warning on line 41 in src/SkinWeightsController.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a pointer-to-const. The current type of "sel" is "class SelectionSet *". 

See more on https://sonarcloud.io/project/issues?id=fernandotonon_QtMeshEditor&issues=AZ521-luGzJsVDTR9PK3&open=AZ521-luGzJsVDTR9PK3&pullRequest=699
View more details on SonarQubeCloud