fix: filter fastapi-only params#1112
Open
francisdbillones wants to merge 1 commit into
Open
Conversation
pydanny
requested changes
Mar 23, 2026
Member
pydanny
left a comment
There was a problem hiding this comment.
Hey @francisdbillones, thanks so much for this PR. It's a nice catch that will help on these sorts of cases. I have one question about a single line of code, I look forward to a better understanding. 😄
| "deprecated", | ||
| } | ||
|
|
||
| if kwargs_supplied := extra.keys() & fastapi_kwargs_with_fixed_values: |
Member
There was a problem hiding this comment.
Why are we testing fastapi_kwargs_with_fixed_values here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
I explicitly defined the kwargs we're passing with fixed values into
Air's internalFastAPIinstance, and made the app factory raise aValueErrorthat points them to thefastapi_approute if they try to pass their own values instead.Fixes issue #1073
Pattern
Followed the existing app factory pattern.
Reviewer Focus
I don't think any special attention is required from the reviewers.
Checklist