fix: runtime type checking for AirResponse.render()#1108
Open
francisdbillones wants to merge 4 commits into
Open
fix: runtime type checking for AirResponse.render()#1108francisdbillones wants to merge 4 commits into
AirResponse.render()#1108francisdbillones wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR implements runtime type checking for
AirResponse.render(), which accepts atagannotated asBaseTag | str | None.Fixes issue #1075
Pattern
I followed similar patterns in
test_templating.pyfor the unit tests.Reviewer Focus
Since
tag's type annotation wasn't being checked at runtime, there are code paths whereNonecould possibly be passed, which seems to be handled inResponse.renderbut doesn't seem to be acknowledged inAirResponse.render. Was wondering if this was intentional or a silent bug.Checklist