Skip to content

Resolved D105 ruff rule#1001

Open
mikhailofff wants to merge 1 commit intofeldroy:mainfrom
mikhailofff:main
Open

Resolved D105 ruff rule#1001
mikhailofff wants to merge 1 commit intofeldroy:mainfrom
mikhailofff:main

Conversation

@mikhailofff
Copy link
Copy Markdown

Issue

#943

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature
    • Core Air (Air Tags, Request/Response cycle, etc)
    • Optional (Authentication, CSRF, etc)
    • Third-Party Integrated (Cookbook documentation on using Air databases or a task manager, etc)
    • Out-of-Scope (Formal integration with databases, external task managers, or commercial services etc - won't be accepted, please create a separate project)
  • Refactoring (no functional changes, no api changes)
  • Chore: Dependency updates, Python version changes, etc.
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Pull request tasks

The following have been completed for this task:

  • Code changes
  • Documentation changes for new or changed features
  • Alterations of behavior come with a working implementation in the examples folder
  • Tests on new or altered behaviors

Checklist

  • I have run just test and just qa, ensuring my code changes passes all existing tests
  • I have performed a self-review of my own code
  • I have ensured that there are tests to cover my changes

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown

@pygarap pygarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But please do: #651 first!

@mikhailofff
Copy link
Copy Markdown
Author

Hi, @pygarap! Please correct me if I'm wrong. When I uncomment the D rule, I see around 645 errors, including some that are not in the ignore list. Therefore, I assumed that issue #943 might be related as a parent to issue #651, as well as the other D subrules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants