Skip to content

Feature/version bump and workflow fixes 3#218

Merged
Zalfsten merged 4 commits intomainfrom
feature/version_bump_and_workflow_fixes_3
Apr 22, 2026
Merged

Feature/version bump and workflow fixes 3#218
Zalfsten merged 4 commits intomainfrom
feature/version_bump_and_workflow_fixes_3

Conversation

@Zalfsten
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Alpine base image version in the API Dockerfile and enhances the Renovate configuration by adding devcontainer support and a specific package rule for Python 3.12. A review comment suggests refining the Python version lock regex in renovate.json to include the Alpine base version, ensuring consistency with the runtime environment and update scripts.

Comment thread renovate.json
Comment on lines +41 to +47
{
"description": "🔒 Python 3.12 global lock (Docker + Devcontainer)",
"matchManagers": ["dockerfile", "devcontainer"],
"matchPackagePatterns": ["python"],
"allowedVersions": "/^3\\.12/",
"groupName": "Python 3.12 runtime"
},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Python version lock regex /^3\.12/ is broad and allows Renovate to update the Alpine base version within the Python tag (e.g., from alpine3.23 to alpine3.24). To maintain consistency with the runtime stage and the update scripts (which rely on a specific Alpine version), it's safer to lock both the Python minor version and the Alpine base version in this rule.

    {
      "description": "🔒 Python 3.12 global lock (Docker + Devcontainer)",
      "matchManagers": ["dockerfile", "devcontainer"],
      "matchPackagePatterns": ["python"],
      "allowedVersions": "/^3\.12\..*-alpine3\.23$/",
      "groupName": "Python 3.12 runtime"
    },

@Zalfsten Zalfsten merged commit c73f49f into main Apr 22, 2026
13 checks passed
@Zalfsten Zalfsten deleted the feature/version_bump_and_workflow_fixes_3 branch April 22, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant