Feature/version bump and workflow fixes 3#218
Conversation
…m:fairagro/m4.2_advanced_middleware_api into feature/version_bump_and_workflow_fixes_2
There was a problem hiding this comment.
Code Review
This pull request updates the Alpine base image version in the API Dockerfile and enhances the Renovate configuration by adding devcontainer support and a specific package rule for Python 3.12. A review comment suggests refining the Python version lock regex in renovate.json to include the Alpine base version, ensuring consistency with the runtime environment and update scripts.
| { | ||
| "description": "🔒 Python 3.12 global lock (Docker + Devcontainer)", | ||
| "matchManagers": ["dockerfile", "devcontainer"], | ||
| "matchPackagePatterns": ["python"], | ||
| "allowedVersions": "/^3\\.12/", | ||
| "groupName": "Python 3.12 runtime" | ||
| }, |
There was a problem hiding this comment.
The Python version lock regex /^3\.12/ is broad and allows Renovate to update the Alpine base version within the Python tag (e.g., from alpine3.23 to alpine3.24). To maintain consistency with the runtime stage and the update scripts (which rely on a specific Alpine version), it's safer to lock both the Python minor version and the Alpine base version in this rule.
{
"description": "🔒 Python 3.12 global lock (Docker + Devcontainer)",
"matchManagers": ["dockerfile", "devcontainer"],
"matchPackagePatterns": ["python"],
"allowedVersions": "/^3\.12\..*-alpine3\.23$/",
"groupName": "Python 3.12 runtime"
},
No description provided.