Skip to content

return EXIT_FAILURE on failure #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
faf0 merged 2 commits into from
Nov 4, 2025
Merged

return EXIT_FAILURE on failure #48

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00af245
return EXIT_FAILURE on failure
1-1sam Nov 3, 2025
a407b41
Update xsct.1
faf0 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/xsct.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ int main(int argc, char **argv)
struct temp_status temp;
int fdebug = 0, fdelta = 0, fhelp = 0, toggle = 0;
Display *dpy = XOpenDisplay(NULL);
int failed = 0;

if (!dpy)
{
Expand Down Expand Up @@ -217,6 +218,7 @@ int main(int argc, char **argv)
screen_specified = atoi(argv[i]);
} else {
fprintf(stderr, "ERROR! Required value for screen not specified!\n");
failed = 1;
fhelp = 1;
}
}
Expand All @@ -228,6 +230,7 @@ int main(int argc, char **argv)
crtc_specified = atoi(argv[i]);
} else {
fprintf(stderr, "ERROR! Required value for crtc not specified!\n");
failed = 1;
fhelp = 1;
}
}
Expand All @@ -236,6 +239,7 @@ int main(int argc, char **argv)
else
{
fprintf(stderr, "ERROR! Unknown parameter: %s\n!", argv[i]);
failed = 1;
fhelp = 1;
}
}
Expand All @@ -247,6 +251,7 @@ int main(int argc, char **argv)
else if (screen_specified >= screens)
{
fprintf(stderr, "ERROR! Invalid screen index: %d!\n", screen_specified);
failed = 1;
}
else
{
Expand Down Expand Up @@ -307,6 +312,7 @@ int main(int argc, char **argv)
if (temp.temp == DELTA_MIN || temp.brightness == DELTA_MIN)
{
fprintf(stderr, "ERROR! Temperature and brightness delta must both be specified!\n");
failed = 1;
}
else
{
Expand All @@ -328,6 +334,6 @@ int main(int argc, char **argv)

XCloseDisplay(dpy);

return EXIT_SUCCESS;
return failed ? EXIT_FAILURE : EXIT_SUCCESS;
}

4 changes: 4 additions & 0 deletions xsct.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ If no arguments are passed, xsct estimates the current display temperature and b
.I [brightness]
Linear brightness between 0.0 (inclusive) and 1.0 (inclusive). The default value is 1.0 if no parameter is passed.

.SH EXIT STATUS
.B xsct
exits with an exit status of 0 on success and >0 on failure.
Comment thread
faf0 marked this conversation as resolved.
Outdated

.SH AUTHOR
xsct is based on sct by Ted Unangst <tedu@openbsd.org>

Expand Down