Skip to content

feature: replace chars to parse 'cfg(...)' keys#10

Merged
facesthe merged 1 commit into
facesthe:mainfrom
mdittmer:replace-chars-for-rust-cfg
May 21, 2026
Merged

feature: replace chars to parse 'cfg(...)' keys#10
facesthe merged 1 commit into
facesthe:mainfrom
mdittmer:replace-chars-for-rust-cfg

Conversation

@mdittmer
Copy link
Copy Markdown
Contributor

Extend instantiate::REPLACE_CHARS to parse 'cfg(...)' keys that are common in Cargo.toml files. Fixes #9.

@mdittmer
Copy link
Copy Markdown
Contributor Author

Please let me know how versioning should be managed here. I have included the -alpha suffix for now because, so far, this is not a feature anyone else (including the project maintainers) have asked for. I am happy to update the PR to follow whatever versioning strategy is preferred (including not updating the version in this PR to separate it from release processes).

@facesthe
Copy link
Copy Markdown
Owner

The prerelease versioning is alright. However, CI checks are failing due to cargo fm --checkt failing. Could you update the PR?

Extend `instantiate::REPLACE_CHARS` to parse `'cfg(...)'` keys that are
common in `Cargo.toml` files.
@mdittmer mdittmer force-pushed the replace-chars-for-rust-cfg branch from 7d38987 to b12211d Compare May 21, 2026 13:03
@mdittmer
Copy link
Copy Markdown
Contributor Author

The prerelease versioning is alright. However, CI checks are failing due to cargo fm --checkt failing. Could you update the PR?

Fixed with cargo fmt and updated single-commit PR.

@facesthe facesthe merged commit b111932 into facesthe:main May 21, 2026
1 check passed
@joshlf
Copy link
Copy Markdown

joshlf commented May 21, 2026

Thanks for the quick turn-around @facesthe! Any chance you could cut a new release? We'd like to use this fix in Anneal.

@facesthe
Copy link
Copy Markdown
Owner

I'll try to get a new release out by the end of the week

@joshlf
Copy link
Copy Markdown

joshlf commented May 22, 2026

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot handle 'cfg(...)' keys commonly used in cargo configuration

3 participants