Skip to content

fix: correct out-of-bounds Vector3 index in AudioSensor::AddSource#2639

Open
Functionhx wants to merge 1 commit into
facebookresearch:mainfrom
Functionhx:fix/audiosensor-vector3-oob
Open

fix: correct out-of-bounds Vector3 index in AudioSensor::AddSource#2639
Functionhx wants to merge 1 commit into
facebookresearch:mainfrom
Functionhx:fix/audiosensor-vector3-oob

Conversation

@Functionhx

Copy link
Copy Markdown

Fixes #2632

Fix off-by-one error in Vector3 indexing: C++ uses 0-based indices [0][1][2], not [1][2][3].

@meta-cla

meta-cla Bot commented Jul 9, 2026

Copy link
Copy Markdown

Hi @Functionhx!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Jul 9, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 9, 2026
@meta-cla

meta-cla Bot commented Jul 9, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AudioSensor::AddSource uses out-of-bounds Vector3 index for source position

1 participant