This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Modularize d2go/tools TARGETS#612
Open
ajinkya-deogade wants to merge 1 commit into
Open
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48461575 |
Summary: Pull Request resolved: facebookresearch#612 The current target definitions for `d2go/tools` do not allow specific components as dependencies, which is causing issues like next diff in the stack where we would like to only depend on `d2go/tools/export` but end up depending on whole of `d2go/d2go`. This was caught by the d2go dependency audit that we have in place (see CI signals https://fburl.com/diff/csnwfffw). Therefore, we are breaking it down into individual targets in a backward compatible way. Differential Revision: D48461575 fbshipit-source-id: 15b4e57e4dba3a42afae84c173a2f2985c7ddf83
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D48461575 |
ajinkya-deogade
force-pushed
the
export-D48461575
branch
from
bbeff3a to
636fdc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The current target definitions for
d2go/toolsdo not allow specific components as dependencies, which is causing issues like next diff in the stack where we would like to only depend ond2go/tools/exportbut end up depending on whole ofd2go/d2go. This was caught by the d2go dependency audit that we have in place (see CI signals https://fburl.com/diff/csnwfffw). Therefore, we are breaking it down into individual targets in a backward compatible way.Differential Revision: D48461575