This repository was archived by the owner on Jan 22, 2025. It is now read-only.
update INJECTED_COCO_DATASETS_LUT when registering AdhocCOCODataset#584
Open
stephenyan1231 wants to merge 1 commit into
Open
update INJECTED_COCO_DATASETS_LUT when registering AdhocCOCODataset#584stephenyan1231 wants to merge 1 commit into
stephenyan1231 wants to merge 1 commit into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46826507 |
Summary: Pull Request resolved: facebookresearch#584 When registering AdhocCOCODataset, INJECTED_COCO_DATASETS_LUT needs to be updated as well. For example, if a dataset uses custom registering function, it can be only retrieved from INJECTED_COCO_DATASETS_LUT. Otherwise, it uses the default registering function as in branch `register_dataset_split`. Reviewed By: antonrigner Differential Revision: D46826507 fbshipit-source-id: 31bc5c79e3b82a20cb798dec37b18d9271040cdf
stephenyan1231
force-pushed
the
export-D46826507
branch
from
a2d4c65 to
4fddaa8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46826507 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
When registering AdhocCOCODataset, INJECTED_COCO_DATASETS_LUT needs to be updated as well.
For example, if a dataset uses custom registering function, it can be only retrieved from INJECTED_COCO_DATASETS_LUT.
Otherwise, it uses the default registering function as in branch
register_dataset_split.Reviewed By: antonrigner
Differential Revision: D46826507