Add sx support to no-conflicting-props eslint rule

[mjames-c]

What changed / motivation ?

sx and className should not be used together (similar to ...stylex.props(...))

Linked PR/Issues

Fixes #1359

Pre-flight checklist

• I have read the contributing guidelines
  Contribution Guidelines
• Performed a self-review of my code

[meta-cla]

Hi @mjames-c!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
stylex	Skipped		Jun 9, 2026 4:23am

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the stylex-no-conflicting-props ESLint rule to flag className/style conflicts not only with stylex.props() spreads, but also with a configurable StyleX “shorthand” prop (default: sx) on host elements.

Changes:

• Add detection for a shorthand StyleX prop (default sx) on lowercase JSX host elements and report conflicting className/style.
• Introduce an sxPropName option (string or false) and tailor report messages based on whether the conflict comes from stylex.props() or shorthand usage.
• Extend unit tests to cover shorthand behavior and configuration.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
packages/@stylexjs/eslint-plugin/src/stylex-no-conflicting-props.js	Adds shorthand-prop detection, new option schema, and message selection logic.
packages/@stylexjs/eslint-plugin/tests/stylex-no-conflicting-props-test.js	Adds valid/invalid cases for shorthand prop conflicts and configuration.

[mjames-c]

this matches the logic in the babel transformer:

stylex/packages/@stylexjs/babel-plugin/src/index.js

Lines 313 to 315 in 20ce0b6

	node.name.type !== 'JSXIdentifier' ||
	typeof node.name.name !== 'string' ||
	node.name.name[0] !== node.name.name[0].toLowerCase()

[mjames-c]

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

my company (Canva) does have a CLA with Meta but I'm waiting to be added to the list of contributors (hopefully by end of week)

[meta-cla]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!