ci: declare workflow-scope permissions on three maintenance workflows#5282
Open
arpitjain099 wants to merge 1 commit into
Open
ci: declare workflow-scope permissions on three maintenance workflows#5282arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
update-cargo-lock, update-yarn-lock and the vscode publish workflow all run with whatever scope the repository default grants. None of them rely on the workflow's own GITHUB_TOKEN: - update-cargo-lock.yml and update-yarn-lock.yml use RELAY_BOT_GITHUB_PAT for peter-evans/create-pull-request, so the workflow token only needs contents:read for actions/checkout. - vscode.yml uses VSCE_PAT for vsce publish, so contents:read again suffices for the workflow token. Pinning the read-only scope brings these three in line with ci.yml, which already declares per-job permissions blocks, and with docusaurus.yml, which uses a workflow-level permissions block. Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds
permissions: contents: readat workflow scope to three small workflows that currently rely on the repository default for their workflowGITHUB_TOKEN:.github/workflows/update-cargo-lock.yml.github/workflows/update-yarn-lock.yml.github/workflows/vscode.ymlIn all three cases the actual write authority comes from a separately-injected secret, not the workflow token:
RELAY_BOT_GITHUB_PATtopeter-evans/create-pull-request, so the workflow token only needs to checkoutvscode.ymlpassesVSCE_PATtovsce publish, same storySo the workflow token only needs
contents: readforactions/checkout. Spelling that out makes the contract explicit and means a future change to the repo's default workflow-token scope (or a compromised third-party action likeactions-rs/toolchainorpeter-evans/create-pull-request, cf. tj-actions/changed-files CVE-2025-30066) can't widen these particular workflows' authority.Style matches
ci.yml(per-job blocks) anddocusaurus.yml(workflow-levelpermissions: contents: write). No behavioural change.