Drop the crossws patch now that devframe binds a Bun transport - #66
Merged
Conversation
devframe 0.9.9 fixed devframes/devframe#317: on Bun/Deno it now binds a runtime-appropriate RPC WebSocket transport (crossws/adapters/bun via Bun.serve) instead of the Node adapter whose environment guard refused to run there. The repo-local guard-stripping patch is therefore obsolete. Remove patches/crossws@0.4.12.patch and its patchedDependencies entry, and bump the devframe/@devframes packages to 0.9.10, @vitejs/devtools and @vitejs/devtools-vite to 0.7.1. Verified under Bun that the dev server starts clean and the embedded DevTools RPC works over the SSE endpoint. Dev-only bumps alongside: oxlint, oxfmt, @types/node, @types/react-dom. CLAUDE.md replaces the patches section with a note that the embedded DevTools RPC runs over SSE rather than WebSocket on Bun, and ROADMAP.md marks the upstream tracking item as fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devframe 0.9.9 fixed devframes/devframe#317: on Bun/Deno it now binds a runtime-appropriate RPC WebSocket transport (crossws/adapters/bun via Bun.serve) instead of the Node adapter whose environment guard refused to run there. The repo-local guard-stripping patch is therefore obsolete.
Remove patches/crossws@0.4.12.patch and its patchedDependencies entry, and bump the devframe/@devframes packages to 0.9.10, @vitejs/devtools and @vitejs/devtools-vite to 0.7.1. Verified under Bun that the dev server starts clean and the embedded DevTools RPC works over the SSE endpoint. Dev-only bumps alongside: oxlint, oxfmt, @types/node, @types/react-dom.
CLAUDE.md replaces the patches section with a note that the embedded DevTools RPC runs over SSE rather than WebSocket on Bun, and ROADMAP.md marks the upstream tracking item as fixed.