🐛 Fix PHP 8.2 deprecation when using DB\Jig with FORMAT_Serialized#411
Open
flaviojdp wants to merge 1 commit into
Open
🐛 Fix PHP 8.2 deprecation when using DB\Jig with FORMAT_Serialized#411flaviojdp wants to merge 1 commit into
flaviojdp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Fix PHP 8.2 deprecation when using DB\Jig with FORMAT_Serialized
PHP 8.2 deprecates dynamic property creation.
When using
DB\JigwithFORMAT_Serialized, this can trigger warnings like:🔁 Steps to reproduce
Then pass the data through template rendering (or any flow that reaches
Base::recursive()).❌ Current behavior
When
$argis an instance ofArrayObjectand$keyis numeric, the following line inBase::recursive():attempts to create a dynamic property like
$arg->0, which is deprecated in PHP 8.2.✅ Expected behavior
No deprecation warnings when handling data from
DB\Jig::FORMAT_Serialized.🧠 Additional context
DB\Jig::FORMAT_JSONFORMAT_Serializedmay returnArrayObjectinstancesArrayObjectis treated like a regular object insiderecursive()💡 Proposed fix
Handle
ArrayObjectusing array access instead of dynamic properties:🚀 Impact