fix: respect particle config z when ParticleTransform.Global is set (#3748)#3749
Open
MohammadYusif wants to merge 1 commit into
Open
fix: respect particle config z when ParticleTransform.Global is set (#3748)#3749MohammadYusif wants to merge 1 commit into
MohammadYusif wants to merge 1 commit into
Conversation
…xcaliburjs#3748) When creating particles with ParticleTransform.Global, the z value from the particle config (this.particle.z) was not being respected. The _createParticle method only passed the emitter-level z (this.z) to each particle, causing any z set in the particle config to be silently ignored. The fix prefers this.particle.z when present and falls back to the emitter's this.z, preserving backward-compatible behavior for users who only set z on the emitter.
MohammadYusif
force-pushed
the
fix/issue-3748
branch
from
5de049c to
e63cc80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
===:clipboard: PR Checklist :clipboard:===
==================
Closes #3748
Changes:
src/engine/particles/particle-emitter.ts, changed thezassignment in_createParticlefromthis.zto(this.particle.z ?? this.z)so that azvalue specified in the particle config takes precedence over the emitter-levelz, while retaining backward compatibility for emitters that only setzon themselvessrc/spec/vitest/particle-spec.ts— one verifying thatparticle.zoverrides the emitter'szwhenParticleTransform.Globalis active, and one verifying the emitter'szis still used as a fallback when noparticle.zis set