fix: make sure to run fonts.init() so preview.py works#1138
Open
therocco wants to merge 1 commit into
Open
Conversation
Signed-off-by: Rocco Augusto <therocco@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rocco Augusto therocco@users.noreply.github.com
Description
While trying to run the
scripts/preview.pyscript to locally test some template modifications I was making for myself I discovered it was erroring out due to anAttributeError: NoneTypeinpwnagotchi/ui/fonts.pyon line 27Motivation and Context
I wanted to play around with the
preview.pyscript and could not do so in it's current state.How Has This Been Tested?
I have generated many screen demos testing it once it was fixed as seen in the attached images.
FIXES #1137
Types of changes
fonts.init()was never being called in thepreview.pyscript so variables that the font module relied on were allNoneTypeChecklist:
git commit -sNo documentation change is required since now the script is working as it is supposed to from the documentation I saw prior.