Skip to content

React to preact #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RamazanIttiev wants to merge 15 commits into
base: main
Choose a base branch
from
Open

React to preact #21

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
599234c
config files from react to preact
RamazanIttiev Aug 5, 2025
7e66608
replaced react types
RamazanIttiev Aug 5, 2025
aa619c6
replaced react tooltip with floating/dom
RamazanIttiev Aug 6, 2025
1a32d9f
fixed eslint bugs
RamazanIttiev Aug 6, 2025
eef6613
fixed tooltip bugs
RamazanIttiev Aug 6, 2025
5c28261
fixed eslint bugs
RamazanIttiev Aug 6, 2025
216084d
removed packageManager from package.json
RamazanIttiev Aug 6, 2025
08f41ce
fixed figma types
RamazanIttiev Aug 6, 2025
b5098a5
removed @preact/compat and fixed .yaml
RamazanIttiev Aug 6, 2025
b2b05d9
removed @preact/signals-core
RamazanIttiev Aug 7, 2025
7c12493
fixed Tooltip.tsx
RamazanIttiev Aug 7, 2025
4cb77c2
removed unnecessary paths
RamazanIttiev Aug 7, 2025
90c435e
removed react-use-clipboard
RamazanIttiev Aug 7, 2025
17e8ebe
removed packageManager
RamazanIttiev Aug 7, 2025
ea33da9
removed @floating-ui/react
RamazanIttiev Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions .eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@ module.exports = {
browser: true,
es2021: true,
},
parser: '@typescript-eslint/parser',
extends: [
'standard-with-typescript',
'plugin:react/recommended',
'plugin:preact/recommended',
'prettier',
'plugin:perfectionist/recommended-alphabetical',
'plugin:tailwindcss/recommended',
Expand All @@ -28,11 +29,13 @@ module.exports = {
sourceType: 'module',
project: './tsconfig.json',
},
plugins: ['react', 'prettier', 'jsx-a11y', 'boundaries'],
plugins: ['preact', 'prettier', 'jsx-a11y', 'boundaries'],
rules: {
'no-undef': 'off',
'react/jsx-no-bind': 'off',
Copy link
Copy Markdown

@followdarko followdarko Aug 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue: I'm not sure, but could we completely get rid of react in any form? Remove or rename this prop?

Otherwise, good job, thank you 👍

Copy link
Copy Markdown
Author

@RamazanIttiev RamazanIttiev Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we cant. There is no such rule as preact/jsx-no-bind. I have tried to remove it but es lint tests don't pass

'import/no-default-export': 'error',
'func-style': ['error', 'expression'],
'react/react-in-jsx-scope': 'off',
'preact/preact-in-jsx-scope': 'off',
'boundaries/element-types': [
2,
{
Expand Down Expand Up @@ -62,14 +65,12 @@ module.exports = {
alias: [
['~api', './src/api'],
['~ui', './src/ui'],
['~hooks', './src/hooks'],
['~utils', './src/utils'],
['~types', './src/types'],
['~test-utils', './src/test-utils'],
],
},
react: {
version: 'detect',
},
'boundaries/elements': [
{
type: 'api',
Expand All @@ -91,6 +92,10 @@ module.exports = {
type: 'test-utils',
pattern: 'src/test-utils/*',
},
{
type: 'hooks',
pattern: 'src/hooks/*',
},
],
},
};
27 changes: 12 additions & 15 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,14 @@
},
"dependencies": {
"@figma/plugin-typings": "^1.79.0",
"@floating-ui/dom": "^1.7.3",
"@floating-ui/react": "^0.25.2",
Copy link
Copy Markdown

@followdarko followdarko Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove @floating-ui/react

"@nanostores/react": "^0.7.1",
"@testing-library/react": "^14.0.0",
"@nanostores/preact": "^1.0.0",
"@preact/compat": "^18.3.1",
"@preact/signals": "^2.2.1",
"@preact/signals-core": "^1.11.0",
Comment thread
ai marked this conversation as resolved.
Outdated
"@types/apca-w3": "^0.1.0",
"@types/culori": "^2.0.0",
"@types/react": "^18.2.14",
"@types/react-dom": "^18.2.6",
"@vitejs/plugin-react": "^4.0.1",
"@vitest/coverage-v8": "^0.34.1",
"apca-w3": "^0.1.9",
"apcach": "^0.6.0",
Expand All @@ -40,9 +40,7 @@
"postcss": "^8.4.24",
"postcss-loader": "^7.3.3",
"postcss-preset-env": "^9.0.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-use-clipboard": "^1.0.9",
"preact": "^10.25.3",
"tailwindcss": "^3.3.2",
"typescript": "^5.0.2",
"uint8-to-hex": "^2.0.0",
Expand All @@ -52,10 +50,11 @@
"vitest": "^0.34.1"
},
"devDependencies": {
"@preact/preset-vite": "^2.10.2",
"@size-limit/preset-small-lib": "^11.2.0",
"@types/node": "^20.4.1",
"@typescript-eslint/eslint-plugin": "^5.61.0",
"@typescript-eslint/parser": "^5.61.0",
"@typescript-eslint/eslint-plugin": "5.61.0",
"@typescript-eslint/parser": "5.61.0",
"eslint": "^8.44.0",
"eslint-config-prettier": "^8.8.0",
"eslint-config-standard-with-typescript": "^36.0.0",
Expand All @@ -64,21 +63,19 @@
"eslint-plugin-jsx-a11y": "^6.7.1",
"eslint-plugin-n": "^15.0.0",
"eslint-plugin-perfectionist": "^1.4.0",
"eslint-plugin-preact": "^0.1.0",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-promise": "^6.0.0",
"eslint-plugin-react": "^7.32.2",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-refresh": "^0.4.1",
"eslint-plugin-tailwindcss": "^3.13.0",
"jsdom": "^22.1.0",
"prettier": "^3.0.2",
"react-use-clipboard": "^1.0.9",
Comment thread
ai marked this conversation as resolved.
Outdated
"size-limit": "^11.2.0",
"terser": "^5.19.0"
},
"size-limit": [
{
"path": "dist/api.js"
}
],
"license": "MIT"
]
}
Loading