Prints graphite url in nagios dashboard for better visibility#13
Prints graphite url in nagios dashboard for better visibility#13sanoojm wants to merge 2 commits into
Conversation
|
@avleen @bugi @edgewortheric @jedi4ever please review. |
| print 'Current value: %s, lower band: %s, upper band: %s' % \ | ||
| (graphite_data, graphite_lower, graphite_upper) | ||
| print 'Current value: %s, lower band: %s, upper band: %s, url: %s' % \ | ||
| (graphite_data, graphite_lower, graphite_upper, url) |
There was a problem hiding this comment.
I'm not currently using nagios, but doesn't the UI allow you to view the command used to run a check, and thus would include the URL? I feel like this adds visual clutter that isn't necessarily useful for everyone who uses this script, so I'd be more inclined to sign off on the change if the display of the URL were optional. (Mind you, I don't think I have commit grants on master, so I'm not sure how much my opinion matters here 😄 )
|
I agree with edgewortheric about clutter. To avoid that part of the display getting too busy, I'd put the url on a second line. IIRC, the classic nagios service dashboard would show the first line of output. Then to see second and later lines the user could click through for more details. It's been quite awhile since I've used check_graphite_data. |
3 participants
No description provided.