Skip to content

Add CONTRIBUTING documentation#460

Draft
danrosen25 wants to merge 2 commits into
esmf-org:developfrom
danrosen25:contributing
Draft

Add CONTRIBUTING documentation#460
danrosen25 wants to merge 2 commits into
esmf-org:developfrom
danrosen25:contributing

Conversation

@danrosen25

@danrosen25 danrosen25 commented Jul 9, 2025

Copy link
Copy Markdown
Member

Add CONTRIBUTING.md file to document the ESMF contribution/pull request process.

View file here: https://github.com/danrosen25/esmf/blob/contributing/CONTRIBUTING.md

@danrosen25

Copy link
Copy Markdown
Member Author

Note that the current coding conventions (a.k.a. syntax guidelines) , although documented in the Developer's Guide, are inconsistent. The best way to follow coding conventions is to follow precedence in key ESMF files. At this time we will not document this process but we plan to cleanup syntax and add guidelines in the future. Doing so will also allow us to add a linter.

@anntsay anntsay marked this pull request as ready for review September 3, 2025 16:51
@anntsay

anntsay commented Jan 21, 2026

Copy link
Copy Markdown
Contributor

@esmf-org/esmf-developers please review this so we could close this ticket for 9.0.0

@danrosen25 danrosen25 added this to the v09.00.00 milestone Jan 21, 2026
@billsacks billsacks removed their request for review January 21, 2026 19:22
@danrosen25 danrosen25 requested a review from a team February 5, 2026 00:55
@danrosen25 danrosen25 marked this pull request as draft March 30, 2026 19:28
@danrosen25

danrosen25 commented Mar 30, 2026

Copy link
Copy Markdown
Member Author

Contributing instructions and guidelines will be modified once devcontainers are in place.
#532

@theurich theurich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks really good! The only one suggestion I have is to make it pretty clear that our Developer's guide is outdated and should be used with caution.

Comment thread CONTRIBUTING.md
* C Reference Manual - [html](https://earthsystemmodeling.org/docs/nightly/develop/ESMC_crefdoc), [pdf](https://earthsystemmodeling.org/docs/nightly/develop/ESMC_crefdoc.pdf)
* NUOPC Reference Manual - [html](https://earthsystemmodeling.org/docs/nightly/develop/NUOPC_refdoc), [pdf](https://earthsystemmodeling.org/docs/nightly/develop/NUOPC_refdoc.pdf)
* ESMPy Documentation - [html](https://earthsystemmodeling.org/esmpy_doc/nightly/develop/html), [pdf](https://earthsystemmodeling.org/esmpy_doc/nightly/develop/ESMPy.pdf)
* Developer’s Guide - [html](https://earthsystemmodeling.org/docs/nightly/develop/dev_guide)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Developer’s Guide - [html](https://earthsystemmodeling.org/docs/nightly/develop/dev_guide)
* Developer’s Guide - [html](https://earthsystemmodeling.org/docs/nightly/develop/dev_guide) (Outdated! Use with caution. Ask if unsure.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants