refactor(0026): Phase 7 (part 2a) — split Agent.Tests per src - #287
Merged
Conversation
Mirrors the 5b src-side Agent split. test/Agent.Tests divided to match the two src projects it covered: - AgentConfigWriterTests, LogTailReaderTests, PairingUrlParserTests -> test/Presentation/Agent/Erp.Presentation.Agent.Common.Tests (references Erp.Presentation.Agent.Common only). - SaveFolderResolverTests -> test/Presentation/Agent/Satisfactory.Presentation.Agent.Tests (references Satisfactory.Presentation.Agent). Namespaces updated Agent.Tests -> the two new ones; dropped the now-vestigial `using Satisfactory.Presentation.Agent;` from the Common tests (verified none reference a Satisfactory-only type). slnx updated. Verified: 23 Common + 4 Satisfactory = 27 tests pass (matches the original Agent.Tests count). The ApiService.Tests split is deliberately separate (part 2b) — it surfaced that ApiService.Tests was dropped from the solution during 5c1/5c2, hiding 14 failing integration tests (dev-Player FK gone after the Auth extraction); that needs a fixture fix, not a mechanical move. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2a of #282 (ADR-0026 phase 7). Mirrors the 5b src-side Agent split.
test/Agent.Testsdivided to match the two src projects it covered:test/Presentation/Agent/Erp.Presentation.Agent.Common.TestsErp.Presentation.Agent.Commontest/Presentation/Agent/Satisfactory.Presentation.Agent.TestsSatisfactory.Presentation.AgentAgent.Tests→ the two new ones; dropped the now-vestigialusing Satisfactory.Presentation.Agent;from the Common tests (verified none reference a Satisfactory-only type).Note: ApiService split is separate (part 2b)
While scoping this I found
ApiService.Testswas silently dropped from the solution during the 5c1/5c2 API refactor — so #276/#277 merged green without those 14 integration tests running. They currently fail with aFOREIGN KEY constraint failed: the fixtures' DI-mintedAgentTokenreferences a dev-Player row that no longer exists, becauseDevPlayerBootstrapmoved to the Auth API in 5c2. That's a fixture fix + re-add, not a mechanical move — tracked for its own PR per discussion.🤖 Generated with Claude Code