Fix a race in epmd#11085
Open
pguyot wants to merge 1 commit into
Open
Conversation
Contributor
CT Test Results 2 files 12 suites 6m 46s ⏱️ Results for commit 236b265. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
jhogberg
requested changes
May 8, 2026
| for (node = g->nodes.reg; node; node = node->next) | ||
| if (is_same_str(node->symname, name)) | ||
| { | ||
| fd_set rfds; |
Contributor
There was a problem hiding this comment.
Nitpick: indentation must use spaces these days, our CI checks for whitespace errors now.
Suggested change
| fd_set rfds; | |
| fd_set rfds; |
Contributor
Author
There was a problem hiding this comment.
I detabbed my changes. FYI the rest of the file still uses tabs.
Contributor
There was a problem hiding this comment.
Thanks, the CI checks only changed lines for now. :)
There is a race where a node can unregister and reregister too fast for epmd to notice as FIN is not processed yet. Handle this by checking if the socket from the other registered node with the same name is being closed. Fixes erlang#11083 Signed-off-by: Paul Guyot <pguyot@kallisys.net>
jhogberg
added
the
testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a race where a node can unregister and reregister too fast for epmd to notice as FIN is not processed yet. Handle this by checking if the socket from the other registered node with the same name is being closed.
Fixes #11083