fix(interpreter): handle non-Spanned variants in wrap_spanned_with_src#867
Open
mwaddip wants to merge 1 commit into
Open
fix(interpreter): handle non-Spanned variants in wrap_spanned_with_src#867mwaddip wants to merge 1 commit into
mwaddip wants to merge 1 commit into
Conversation
Wrap bare `EvalError` variants instead of panicking. The diagnostic retry path in `reduce_to_crypto` can hit `wrap_spanned_with_src` with an unspanned variant (e.g. `InvalidResultType`, `UnexpectedExpr`); the type-checking parser keeps this off the consensus path, but fuzzers and external reduce-helper code can reach it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap bare
EvalErrorvariants instead of panicking. The diagnostic retrypath in
reduce_to_cryptocan hitwrap_spanned_with_srcwith anunspanned variant (e.g.
InvalidResultType,UnexpectedExpr); thetype-checking parser keeps this off the consensus path, but fuzzers and
external reduce-helper code can reach it.