Replace core2 with no-std-io2#863
Open
sethdusek wants to merge 2 commits into
Open
Conversation
sethdusek
force-pushed
the
corez
branch
2 times, most recently
from
4decf66 to
3fe2abf
Compare
core2 was recently (unexpectedly) yanked. We only use it for IO traits so this isn't a big deal, we can just use no_std_io2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core2 was recently unexpectedly yanked from crates.io. Since we only use core2 for its IO traits in no_std, this isn't a huge issue. Ideally whenever rust-lang/rust#154046 is resolved we would remove our reliance on external std::io implementations entirely.
Currently I am considering vendoring no_std_io2 under the ergoplatform organization to avoid similar issues in the future