Fix panic in gen_indexes when index modulo N equals zero#847
Open
mwaddip wants to merge 1 commit into
Open
Conversation
to_u32_digits() returns an empty vec for BigInt(0). Accessing .1[0] panics. Replace with .first().copied().unwrap_or(0) to match the JVM reference behavior (BigInt.toInt returns 0).
Pull Request Test Coverage Report for Build 23799568905Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gen_indexespanics when any of the 32 extracted 4-byte hash windows,interpreted as an unsigned big-endian integer, is an exact multiple of N.
The modulo result is zero,
BigInt::to_u32_digits()returns an emptydigit vector, and
.1[0]panics with index out of bounds.The JVM reference (
AutolykosPowScheme.scala) handles this correctlyvia
BigInt.toInt, which returns 0 forBigInt(0).Fix
Replace
.1[0]with.1.first().copied().unwrap_or(0)— returns 0when the digit vector is empty, matching JVM behavior.
Risk
With 32 indices per header and N starting at ~67M, there is a non-trivial
cumulative probability that some mainnet block triggers this during
initial chain sync. The fix is a one-line change with no behavioral
difference for non-zero results.
Test plan
test_gen_indexes_zero_modulothat triggersthe exact panic condition (seed hash with 4-byte window equal to N)
cargo clippycleancargo fmtclean