Resolve pvxlist hostnames in server arguments#175
Open
derekste wants to merge 1 commit intoepics-base:masterfrom
Open
Resolve pvxlist hostnames in server arguments#175derekste wants to merge 1 commit intoepics-base:masterfrom
derekste wants to merge 1 commit intoepics-base:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pvxlistserver arguments are expected to work withIP[:port], but hostnames/FQDNs can currently fail even when normal DNS resolution succeeds.This resolves command-line server arguments before passing them to
.server(), preserving the original argument in user-facing output.Example
Before:
pvxlist bidaq0-bbdcct.domain.gov
From bidaq0-bbdcct.domain.gov : Error resolving "bidaq0-bbdcct.domain.gov" : nodename nor servname provided, or not known
After
pvxlist bidaq0-bbdcct.domain.gov
BOOSTER:DCCTWF
also works for hostname(non-FQDN):port and other valid combinatons