server: monitor TX check buffer level on each iteration#164
Open
mdavidsaver wants to merge 1 commit intoepics-base:masterfrom
Open
server: monitor TX check buffer level on each iteration#164mdavidsaver wants to merge 1 commit intoepics-base:masterfrom
mdavidsaver wants to merge 1 commit intoepics-base:masterfrom
Conversation
mdavidsaver
force-pushed
the
servermon-backlog
branch
from
487f6e5 to
aabdc91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to address #161. Move check on connection buffer from
maybeReply(), run when deciding whether to start draining subscription queue, into the beginning ofdoReply(). There it will be run on each iteration.Running only the first time permits a situation where a busy publishing can grow the queue without bound by keeping
doReply()from idling.