Feat/split store interface by pfleidi · Pull Request #1474 · entireio/cli

pfleidi · 2026-06-18T23:43:55Z

https://entire.io/gh/entireio/cli/trails/614

This draft pull request was opened by Entire after CI was requested for the linked trail. Feel free to edit the title or body — the link above is what keeps the trail and PR connected.

Summary

Split checkpoint storage interfaces so committed checkpoint metadata and git-only shadow-branch storage no longer share one fat Store surface.

Replace the combined checkpoint.Store interface with CommittedStore, CommittedWriter, TemporaryStore, and optional AuthorReader.
Update checkpoint.Open / Stores so Primary exposes committed storage and Temporary() exposes shadow-branch storage, while the current git backend still backs both.
Route production callers through narrower committed or temporary interfaces; explain now reads checkpoint authors only when the committed store supports AuthorReader.

No behavior change intended.

Note

Medium Risk
Wide refactor across checkpoint persistence and every major read/write path; behavior is intended to be unchanged but regressions in attach, resume, condensation, or attribution are plausible if ref resolution or not-found handling diverges subtly.

Overview
Replaces the single fat checkpoint.Store with layered interfaces: TemporaryStore for shadow-branch work, and CommittedStore (session + checkpoint read/write) for entire/checkpoints/v1. checkpoint.Open now types Primary as CommittedStore and Temporary() as TemporaryStore, still backed by the same GitStore.

Adds committed_domain.go with SessionRef (LatestSessionRef, SessionIndexRef, SessionIDRef), ReadOption / WriteOption, and façade methods ReadCheckpoint, ReadSession, WriteSession, UpdateSession, UpdateCheckpoint. Production code is migrated off WriteCommitted, ReadCommitted, ListCommitted, UpdateCommitted, and per-index metadata helpers to these entry points.

CLI and strategy paths (attach, attribution, explain, resume, rewind, dispatch, manual-commit hooks/condensation) depend on smaller interfaces (committedCheckpointReader, optional AuthorReader) and treat missing checkpoints via ErrCheckpointNotFound where summaries used to be nil. Tests and bench fixtures follow the new API.

^{Reviewed by Cursor Bugbot for commit 887b239. Configure here.}

Replace the combined checkpoint Store interface with committed, temporary, and optional author capabilities. This keeps the current GitStore implementation while making the committed storage surface independent from shadow-branch operations. Entire-Checkpoint: b6e36ed89559

Expose committed and temporary checkpoint storage through separate interfaces from the Stores facade. Call sites now depend on committed readers and writers or temporary shadow-branch storage instead of the concrete GitStore. Entire-Checkpoint: bb51dce048b6

Copilot

Pull request overview

This PR refactors the checkpoint storage API by splitting the previously unified GitStore surface into capability-based interfaces for committed checkpoint operations vs. temporary (shadow-branch) operations, and updates strategy + CLI call sites to use the narrower interfaces.

Changes:

Introduces checkpoint.CommittedStore / checkpoint.TemporaryStore capability interfaces and updates checkpoint.Open() to return a facade (Stores) exposing both.
Updates manual-commit strategy paths (save/rewind/condense) to use Stores.Temporary() for shadow-branch operations and committed interfaces for v1 metadata reads/writes.
Updates CLI features (explain/resume/attach/attribution) and tests to consume the new interfaces and new committed-reading helpers.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
cmd/entire/cli/strategy/manual_commit.go	Adds `getCheckpointStores` helper and narrows `getCheckpointStore` to `CommittedStore`.
cmd/entire/cli/strategy/manual_commit_test.go	Updates committed-read test flow to use `ReadCommittedCheckpoint` + `ReadLatestSessionContent`.
cmd/entire/cli/strategy/manual_commit_rewind.go	Switches rewind listing to use `TemporaryStore` from `Stores.Temporary()`.
cmd/entire/cli/strategy/manual_commit_git.go	Switches shadow-branch writes to `TemporaryStore` from `Stores.Temporary()`.
cmd/entire/cli/strategy/manual_commit_condensation.go	Updates doc comment to reference `CommittedStore` committed writes.
cmd/entire/cli/resume.go	Narrows helper to accept `checkpoint.CommittedListReader` instead of `*GitStore`.
cmd/entire/cli/explain.go	Uses `CommittedStore` in lookup and type-asserts optional author lookup via `AuthorReader`; narrows temp helpers to `TemporaryStore`.
cmd/entire/cli/checkpoint/store.go	Updates compile-time interface assertions for `GitStore` capabilities.
cmd/entire/cli/checkpoint/open.go	Updates `Stores` to expose `Primary CommittedStore` + `Temporary() TemporaryStore`.
cmd/entire/cli/checkpoint/committed.go	Updates `LookupSessionLog` to use `ReadRawSessionLogForCheckpoint` helper on a committed reader.
cmd/entire/cli/checkpoint/committed_reader_resolve.go	Introduces committed capability interfaces (`CommittedWriter`, `CommittedStore`) and optional `AuthorReader`.
cmd/entire/cli/checkpoint/checkpoint.go	Replaces prior combined store interface with `TemporaryStore` capability interface.
cmd/entire/cli/attribution.go	Narrows attribution resolver store dependency to a capability interface instead of `*GitStore`.
cmd/entire/cli/attach.go	Narrows attach store opening to return `CommittedStore` interface.

SaveStep, SaveTaskStep, and GetRewindPoints each repeated the getCheckpointStores + Temporary() pair. A getTemporaryStore accessor mirrors getCheckpointStore so each call site is a single line, with getCheckpointStores remaining the shared open-with-blob-fetcher wrapper. Entire-Checkpoint: 684fdbdfe046

pfleidi · 2026-06-18T23:51:44Z

Bugbot run

Keep empty-session checkpoints distinct from missing checkpoints when reading latest session content. Also narrow resume checkpoint metadata resolution to the methods it actually uses so the split store interfaces stay precise. Entire-Checkpoint: 8e67ab6c5252

Exercise the concrete GitStore latest-session reader in the redaction failure regression test. This keeps the test checking that dropped transcripts surface ErrNoTranscript after condensation still writes checkpoint metadata. Entire-Checkpoint: 02eff406bed3

Keep attribution resolution dependent only on the committed summary and session metadata methods it uses. Add a focused test with a reader that omits unused session-content methods so the local interface stays precise. Entire-Checkpoint: 136650505f9c

pfleidi · 2026-06-19T00:41:24Z

Bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 772908f. Configure here.}

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Return ErrCheckpointNotFound for empty committed summaries in the split reader helper. This keeps the interface split behavior-neutral and updates the regression test to cover the pre-split contract. Entire-Checkpoint: b7a703224f22

Introduce session and checkpoint document interfaces over the existing git committed storage layout. The new GitStore adapters preserve the old on-disk behavior while exposing SessionRef-based reads and option-based backfills for later caller migration. Entire-Checkpoint: 51f5a0ee3b11

Move committed checkpoint callers to the split checkpoint and session store surface. GitStore keeps the low-level v1 methods internally, but production callers now depend on ReadCheckpoint, ReadSession, WriteSession, UpdateSession, and UpdateCheckpoint. Entire-Checkpoint: 7319e37bab43

pfleidi · 2026-06-19T02:34:54Z

Bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 887b239. Configure here.}

Copilot

Pull request overview

Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.

Route legacy summary updates through the session update API and reuse the committed checkpoint reader from attribution code. This keeps committed read/write behavior centralized without changing the public call sites. Entire-Checkpoint: 854458fe9b0a

Rename the committed checkpoint metadata store interface to avoid the generic Store name. Also fast-path indexed session refs so callers that already know a session index do not re-read the checkpoint summary. Entire-Checkpoint: 7ecf2c5cef5a

pfleidi added 2 commits June 18, 2026 16:27

Copilot AI review requested due to automatic review settings June 18, 2026 23:43

Copilot started reviewing on behalf of pfleidi June 18, 2026 23:44 View session

pfleidi marked this pull request as ready for review June 18, 2026 23:44

pfleidi requested a review from a team as a code owner June 18, 2026 23:44

Copilot AI reviewed Jun 18, 2026

View reviewed changes

Comment thread cmd/entire/cli/attribution.go Outdated

cursor Bot reviewed Jun 18, 2026

View reviewed changes

Comment thread cmd/entire/cli/checkpoint/committed.go Outdated

pfleidi added 3 commits June 18, 2026 17:18

pfleidi requested a review from Copilot June 19, 2026 00:41

Copilot started reviewing on behalf of pfleidi June 19, 2026 00:41 View session

cursor Bot reviewed Jun 19, 2026

View reviewed changes

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Comment thread cmd/entire/cli/checkpoint/committed_reader_resolve.go Outdated

pfleidi added 3 commits June 18, 2026 17:58

preserve empty summary lookup behavior

f39e8db

Return ErrCheckpointNotFound for empty committed summaries in the split reader helper. This keeps the interface split behavior-neutral and updates the regression test to cover the pre-split contract. Entire-Checkpoint: b7a703224f22

pfleidi commented Jun 19, 2026

View reviewed changes

Comment thread cmd/entire/cli/checkpoint/committed_domain.go Outdated

pfleidi requested a review from Copilot June 19, 2026 02:34

Copilot started reviewing on behalf of pfleidi June 19, 2026 02:35 View session

cursor Bot reviewed Jun 19, 2026

View reviewed changes

Copilot AI reviewed Jun 19, 2026

View reviewed changes

Comment thread cmd/entire/cli/checkpoint/committed_domain.go

pfleidi added 2 commits June 18, 2026 19:46

dedupe committed summary helpers

27b0e0d

Route legacy summary updates through the session update API and reuse the committed checkpoint reader from attribution code. This keeps committed read/write behavior centralized without changing the public call sites. Entire-Checkpoint: 854458fe9b0a

address committed store feedback

9efa5de

Rename the committed checkpoint metadata store interface to avoid the generic Store name. Also fast-path indexed session refs so callers that already know a session index do not re-read the checkpoint summary. Entire-Checkpoint: 7ecf2c5cef5a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/split store interface#1474

Feat/split store interface#1474
pfleidi wants to merge 11 commits into
mainfrom
feat/split-store-interface

pfleidi commented Jun 18, 2026 •

edited by cursor Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

pfleidi commented Jun 18, 2026

Uh oh!

Uh oh!

pfleidi commented Jun 19, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

pfleidi commented Jun 19, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

pfleidi commented Jun 18, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

pfleidi commented Jun 18, 2026

Uh oh!

Uh oh!

pfleidi commented Jun 19, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

pfleidi commented Jun 19, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

pfleidi commented Jun 18, 2026 •

edited by cursor Bot

Loading