fix(activity): truncate repo names rune-safely in repo chart#1473
Merged
Conversation
renderRepoChart shortened long repo names with a byte slice (name[:maxNameLen-1] + ellipsis), which can split a multi-byte UTF-8 rune and emit invalid UTF-8 to the terminal. Reuse the existing rune-aware padOrTruncate helper (consistent with the commit-list path) and add a regression test mirroring TestRenderCommitList_UnicodeMessageSafeTruncation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Soph
approved these changes
Jun 19, 2026
Collaborator
|
Thanks! 🫶 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
renderRepoChart(theentire activityrepo chart) shortened long repo nameswith a byte slice —
name[:maxNameLen-1] + "…". For repo names containingmulti-byte UTF-8 (accents, non-Latin scripts, emoji), that can split a rune
mid-byte and emit invalid UTF-8 to the terminal.
This reuses the file's existing rune-aware
padOrTruncatehelper — the same onethe commit-list path already relies on — which also removes the duplicated
truncate-and-pad logic.
Test
Adds
TestRenderRepoChart_UnicodeNameSafeTruncation, mirroring the existingTestRenderCommitList_UnicodeMessageSafeTruncation: it renders a long,multi-byte repo name and asserts the output is valid UTF-8 and still truncated.
The test fails on the previous byte-slicing code and passes with this change.